1830050 - Permafailing GTEST ImportScanner.Supports | Expected equality of these values when Gecko 114 merges to Beta on 2023-05-08

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Natalia Csoregi [:nataliaCs]]

• Central-as-beta-simulation
• How to run these simulations
• Failure log

[task 2023-04-26T11:54:45.172Z] 11:54:45     INFO -  TEST-START | ImportScanner.Supports
[task 2023-04-26T11:54:45.173Z] 11:54:45  WARNING -  TEST-UNEXPECTED-FAIL | ImportScanner.Supports | Expected equality of these values:
[task 2023-04-26T11:54:45.173Z] 11:54:45     INFO -    urls.Length()
[task 2023-04-26T11:54:45.173Z] 11:54:45     INFO -      Which is: 5
[task 2023-04-26T11:54:45.173Z] 11:54:45     INFO -    3u
[task 2023-04-26T11:54:45.173Z] 11:54:45     INFO -      Which is: 3 @ /builds/worker/checkouts/gecko/layout/style/test/gtest/ImportScannerTest.cpp:99
[task 2023-04-26T11:54:45.173Z] 11:54:45  WARNING -  TEST-UNEXPECTED-FAIL | ImportScanner.Supports | test completed (time: 0ms)

:canadahonk this was triggered by Bug 1827941.
Can you take a look into this?
Thank you.

Comment 1

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1830050 - Fix ImportScanner.Supports gtest expectations

Fixed ImportScanner.Supports gtest presuming the import supports pref is
always on by accounting for the pref in the expectations.

Comment 2

[Oliver Medhurst [:canadahonk]]

Expectations presumed the pref for it (layout.css.import-supports.enabled) was always on and didn't catch in testing as it is enabled in nightlies, fixed expectations to account for the pref value in patch above.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53e0f79b00a3
Fix ImportScanner.Supports gtest expectations r=emilio

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/53e0f79b00a3

Comment 5

[Serban Stanca [:SerbanS]]

Verified fixed in today’s beta simulation push.