1830058 - Extend query_stripping_count_by_param to account for updated query strip list

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Emma Zühlcke [:emz]]

We've recently extended the list, let's extend the histogram so we can see the distribution of known query params stripped.

To do this, we need to extend the list here: https://searchfox.org/mozilla-central/rev/8329a650e3b4f866176ae54016702eb35fb8b0d6/toolkit/components/telemetry/Histograms.json#13508-13515 to include the new params in https://firefox.settings.services.mozilla.com/v1/buckets/main/collections/query-stripping/records (data[0]).
Note that all histogram labels need to be prefixed with param_. So if you want to add a query param foo to the telemetry probe you need to add param_foo.

This test also needs to be updated to account for the extended label list: https://searchfox.org/mozilla-central/source/toolkit/components/antitracking/test/browser/browser_urlQueryStringStripping_telemetry_2.js

Comment 1

[Aakash Shah]

Hi,

I would like to work on this bug

Comment 2

[Aakash Shah]

This would be my first bug -- thanks so much for the detailed instructions

Comment 3

[Emma Zühlcke [:emz]]

Thanks for taking it! I've assigned you. Let me know if you have any questions.

Comment 4

[Aakash Shah]

can you point a link to how to send this for review? I have mercurial installed, just don't know the workflow

Comment 5

[Aakash Shah]

reading this: https://firefox-source-docs.mozilla.org/contributing/reviews.html but still don't know how to get my changset linked to this bug

Comment 6

[Aakash Shah]

also curious how to run the test locally

Comment 7

[Emma Zühlcke [:emz]]

I recommend to follow the instructions here: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

You need to link your commit to the bug by adding the but number in the commit message, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#commit-message

After that you can use moz-phab to submit the patch for review: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-submit-a-patch

Here is how you can run tests locally: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html#to-test-a-change-locally

Happy to answer any additional questions!

Comment 8

[Aakash Shah]

https://phabricator.services.mozilla.com/D177667

Comment 9

[Aakash Shah]

Attachment: Bug 1830058 - extended query_stripping_count_by_param to account for updated query strip list r?pbz

Comment 10

[Aakash Shah]

Attachment: Bug 1830058 - fix lint error. r?pbz

Depends on D177667

Comment 11

[Emma Zühlcke [:emz]]

Aakash are you still working on it? If not I would like to assign the bug to somebody else.

Comment 12

[Emma Zühlcke [:emz]]

Hmm, I don't see any recent activity and there is still a pending NI. It would be good to get telemetry coverage sooner rather than later. Abhishek, do you have time to take over this bug? It's fairly straightforward.

Comment 13

[Abhishek Madan[:abhishekmadan]]

I can take this bug

Comment 14

[Abhishek Madan[:abhishekmadan]]

Attachment: Bug 1830058 - Extend query_stripping_count_by_param to account for updated query strip list. r?#anti-tracking

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5342bde81217
Extend query_stripping_count_by_param to account for updated query strip list. r=anti-tracking-reviewers,pbz

Comment 16

[Cristina Horotan [:chorotan]]

Backed out changeset 5342bde81217 (Bug 1830058) for causing build bustages at TelemetryHistogramEnums.h

Backout: https://hg.mozilla.org/integration/autoland/rev/3916cec2b11b6d2d44733ef383d647cec887ac87

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=5342bde81217b1ab817cd3feb33097e440f51137

Failure log: https://treeherder.mozilla.org/logviewer?job_id=421935416&repo=autoland&lineNumber=7208

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e0fbfeb53e2
Extend query_stripping_count_by_param to account for updated query strip list. r=anti-tracking-reviewers,pbz

Comment 18

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/9e0fbfeb53e2