1830086 - Include Firefox version in saved PDF metadata

Status: VERIFIED FIXED

(Core :: Printing: Output, enhancement, P3)

Description

[Mihai Popa [:papermario]]

Attachment: Metadata screenshot

*** This bug maybe is a duplicate of bug #1762258 ***

Steps to reproduce:

Open a test document,like https://bugzilla.mozilla.org/show_bug.cgi?id=1759821, open the Print menu (click menu-print or press Ctrl+P), select the printer to "Save as PDF", save as PDF and inspect the metadata.

Actual results:

No Firefox version in saved PDF metadata. Currently, it's: "Mozilla Firefox", but no version!
See attached screenshot!

Expected results:

Add the Firefox version in saved PDF metadata like so: Mozilla Firefox 112.0.1

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Code lives here, seems like a natural extension to bug 1762258?

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1830086: Add Firefox version to PDF metadata. r=#layout-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad04c494cb3c
Add Firefox version to PDF metadata. r=emilio

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ad04c494cb3c

Comment 5

[Monica Chiorean]

I was able to reproduce the issue on Win10 using FF build 114.0a1(20230426170915).
Verified as fixed on Win10/Ubuntu 20.04 using FF builds 115.0 and 116.0a1(20230626215144).

Only on Mac 12.6 the issue is still reproducing on both Nightly and Beta meaning that only general Firefox/Firefox Nightly is displayed as Creator. Is this expected? Thank you.

Comment 6

[David Shin[:dshin]]

Ahhh, MacOS uses a different code path. I missed that.
I don't really have a Mac, but I may be able to procure it for a short time. Til then, since it's not a regression, and solves the problem for other OSes, I'm spinning a separate MacOS ticket.

Comment 7

[Monica Chiorean]

Should I close this issue as the Mac Os issue is logged separately? Thank you.

Comment 8

[David Shin[:dshin]]

Whoops - sorry, yeah, closing it since you verified on Windows and Ubuntu.