Closed Bug 1830139 Opened 3 years ago Closed 3 years ago

Increase max timer bundling delay for longer-running timers

Categories

(Core :: XPCOM, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: jlink, Assigned: jlink)

References

Details

(Keywords: perf-alert)

Attachments

(1 file)

The current maximum by which a single timer can be delayed in order bundle it with other timers is 100ms. This is sufficient for short and medium-duration timers but long-duration timers could easily be re-scheduled by a more significant amount in order to enable more bundling. Since the acceptable delay for a timer is already a function of the duration of the timer we should just increase the cap (which effectively only applies to the longer-duration timers).

This allows long-duration timers to be re-scheduled with greater
flexibility.

Pushed by jlink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8543ea21ab87 Increased the maximum timer delay from 100ms to 10000ms r=smaug
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

(In reply to Pulsebot from comment #2)

Pushed by jlink@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8543ea21ab87
Increased the maximum timer delay from 100ms to 10000ms r=smaug

== Change summary for alert #38284 (as of Fri, 05 May 2023 04:19:37 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
7% welcome loadtime linux1804-64-shippable-qr fission warm webrender 48.06 -> 44.79 Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=38284

Regressions: 1832529
Blocks: 1838557
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: