183017 - Only numbers displayed when bar chart contains too many products

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect, P3)

Description

[David Lawrence [:dkl]]

When choosing more than one product and too many components from the chart query
screen, a bar chart is created with only numbers and no bars. Backing down the
list of components or products fixes the problem. There should be a way to
dynamically resize the image to accommodate the additional data or put a warning
that you have selected too many items.

Comment 1

[Gervase Markham [:gerv]]

Can't you resize it yourself? :-) I'd much rather have smart users decide what
the right size is than dumb code, which is more likely to get it wrong.

Gerv

Comment 2

[Göran Uddeborg]

One of us misunderstand something here.

The report is a PNG picture, which does not contain any bars.  Sure I carn
resize the picture, but it will still only contain numbers!

In this bugzilla, you can repeat like this:

1. Select reports
2. Select "Graphical Reports"
3. Select "Component" on vertical axis
4. Select "Resolution" on horizontal axis
5. Leave plot data sets as "Individually" (the default)
6. Leave format as "bar chart" (the default)
7. Remove the preselected statuses, and any other preselections
8. Select all components starting with "A" (14 in total)
9. Click "Generate Report"

Now, try to resize this picture so that you see the bars! :-)

Comment 3

[Gervase Markham [:gerv]]

10. Click the link marked "Wider" below the bars. Continue until bars appear.

Gerv

Comment 4

[Göran Uddeborg]

You mean "fatter" rather than "wider", I presume.

I had tried it, but obviously not many enough times.

I take your point, you can get the report.

I don't find it immediately obvious you should click "fatter" half a dozen times
in a case like this.  So I still think some kind of warning or extra explanation
on the page would be appropriate.  A little section about this potential problem
below the graph, for example.

But it is possible to get the report, so it's a usability issue rather than a
real bug.

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch implements a minimum width for bar charts, meaning that you always
see the bars (each entry requires 10 pixels.)

Gerv

Comment 6

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Always read patches before uploading them...

Gerv

Comment 7

[Gervase Markham [:gerv]]

Comment on attachment 110931 [details] [diff] [review]
Patch v.2

Joel: you're my right-hand man for reporting; could you take a look at this
fix?

Gerv

Comment 8

[Joel Peshkin]

Comment on attachment 110931 [details] [diff] [review]
Patch v.2

The min_width needs to be wider.  20 works for me.
r=joel

Comment 9

[Gervase Markham [:gerv]]

joel: doubling the value of the min-width has a serious effect on the way this
patch works. It always worked at 10 pixels for me; can you give me the URL of a
graph on landfill where it doesn't for you?

Gerv

Comment 10

[Joel Peshkin]

I'll have to try some experiments to see what happens.  I may have overridden
the patche's normal choice when I got it to "still" display only numbers.  The
patch definitely improves the situation regardless.  

Comment 11

[Gervase Markham [:gerv]]

joel: ping? :-)

Gerv

Comment 12

[Joel Peshkin]

Let's land this.

Comment 13

[Gervase Markham [:gerv]]

Fixed.

Checking in report.cgi;
/cvsroot/mozilla/webtools/bugzilla/report.cgi,v  <--  report.cgi
new revision: 1.13; previous revision: 1.12
done

Gerv