1830275 - WebRTC: Implement DeviceInfo::DeviceChange() in DeviceInfoPipewire

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement)

Description

[Jan Grulich]

This is a missing functionality in the PipeWire implementation in WebRTC. Without this functionality we won't be notified about newly added or removed camera and the list of cameras presented to the user won't reflect the real state.

Comment 1

[Jan Grulich]

Attachment: Bug 1830275 - Add missing support for device change notifications r=pehrsons

Registers each DeviceInfoPipeWire in PipeWireSession we use and calls
DeviceChange() for each once there is a new camera added or removed to
invoke OnDeviceChange() for every registered VideoInputFeedback.

Comment 2

[Jan Grulich]

Attachment: Bug 1830275 - WebRTC backport: PipeWire camera: make member variable with the PipeWire status updated r=pehrsons

We keep information about the PipeWire camera status as a member of the
PipeWire session, but it's never updated and remains in uninitialized
state. Make sure it gets updated once PipeWire is initialized or when it
fails. There is currently no use for this member variable, but there is
a plan to use it so I'm rather keeping it instead of removing it.

This is a simple backport of an WebRTC upstream change.

Upstream commit: 3881cb65cfcec90b6f0a56ce7223a471aa0115f2

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78bd1d147bff
WebRTC backport: PipeWire camera: make member variable with the PipeWire status updated r=pehrsons,webrtc-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/78bd1d147bff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60eb5ef11c8d
Add missing support for device change notifications r=pehrsons,webrtc-reviewers

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/60eb5ef11c8d