Closed
Bug 1830282
Opened 3 years ago
Closed 3 years ago
Replace Focus UrlUtils.java methods with URLStringUtils from AC
Categories
(Focus :: General, task, P2)
Tracking
(firefox115 verified)
VERIFIED
FIXED
115 Branch
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | verified |
People
(Reporter: mcarare, Assigned: mcarare)
References
Details
Attachments
(1 file)
We should move to using the AC Kotlin implementation instead of the Java one.
This includes completely removing the file and replace methods with the AC ones, as well as migrating the methods that do not have an equivalent in AC to the AC URLStringUtils ( including tests).
Comment 1•3 years ago
|
||
Comment 2•3 years ago
|
||
Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/bf5869050d6c3621986cd10ff5b494a99d93c36e
[main] Bug 1830282 - Replace Focus UrlUtils.java methods with URLStringUtils from AC.
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox114:
--- → fixed
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
| Assignee | ||
Comment 3•3 years ago
|
||
For QA: Test that the following flows work as expected:
- Adding a new search engine.
- Opening a new page by typing the URL.
- Adding a website to device home screen shortcuts ( check proper default page title generated).
- Adding a website to app home screen shortcuts (AKA topsites - check proper representative image generated)
Thank you!
Updated•3 years ago
|
status-firefox114:
fixed → ---
status-firefox115:
--- → fixed
Target Milestone: 114 Branch → 115 Branch
Comment 4•3 years ago
|
||
Verified as implemented on the latest Focus Nightly 115.0a1 build from 5/10, with the following devices:
- Google Pixel 6 (Android 13),
- HTC 10 (Android 8),
- Lenovo tab M10 (Android 10).
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•