Closed Bug 1830282 Opened 3 years ago Closed 3 years ago

Replace Focus UrlUtils.java methods with URLStringUtils from AC

Categories

(Focus :: General, task, P2)

All
Android
task

Tracking

(firefox115 verified)

VERIFIED FIXED
115 Branch
Tracking Status
firefox115 --- verified

People

(Reporter: mcarare, Assigned: mcarare)

References

Details

Attachments

(1 file)

We should move to using the AC Kotlin implementation instead of the Java one.

This includes completely removing the file and replace methods with the AC ones, as well as migrating the methods that do not have an equivalent in AC to the AC URLStringUtils ( including tests).

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: qe-verify+
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch

For QA: Test that the following flows work as expected:

  • Adding a new search engine.
  • Opening a new page by typing the URL.
  • Adding a website to device home screen shortcuts ( check proper default page title generated).
  • Adding a website to app home screen shortcuts (AKA topsites - check proper representative image generated)

Thank you!

Target Milestone: 114 Branch → 115 Branch

Verified as implemented on the latest Focus Nightly 115.0a1 build from 5/10, with the following devices:

  • Google Pixel 6 (Android 13),
  • HTC 10 (Android 8),
  • Lenovo tab M10 (Android 10).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: