1830328 - Multiple Top Pick's favicons look blurry

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Unity.mp4

[Affected versions]:

• Nightly 114.0a1
• Beta 113.0b8
• Firefox 112.0.1

[Affected Platforms]:

• Mac 12.4
• Windows 10 x64
• Linux Mint 20

[Prerequisites]:

• Have a new profile with the following prefs set:
• browser.search.region to US
• browser.urlbar.quicksuggest.dataCollection.enabled to true
• browser.urlbar.merino.providers to adm,top_picks
• browser.urlbar.bestMatch.enabled to true

[Steps to reproduce]:

1. Open the Nightly browser with the profile from the prerequisites.
2. Quickly type "dell" in the awesome bar.
3. Observe the Top Pick's favicon.

[Expected result]:

• The favicon is not blurry.

[Actual result]:

• The favicon looks blurry.

[Notes]:

• Here is a list of keywords that I have found that trigger a Top Pick result with a blurry favicon: Facebook, Dell, Yandex, Life 360, phys, aa, uhc, weibo. Probably there are more results that have blurry favicons, but I didn't manage to go through all the list yet.
• Attached is a screen recording of the issue.

Comment 1

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: blurry top picks.mp4

Comment 2

[Abhishek]

I investigated this blurry behavior and all of the domains except life360.com in the video above have low resolution (all of them are below 52x52) favicons. The favicon for life360.com is 150x150 wide. I am not sure why it is appearing blurry.

We plan to filter out all the domains that don't have high resolution favicons. Filtering out all domain favicons below 150x150 just so that we can filter out life360.com will result into too few domains with actual favicons coming from the website itself. Hence we are setting the high resolution value to be 52x52.

A fix for it is already in review https://github.com/mozilla-services/merino-py/pull/286.

Comment 3

[Nan Jiang [:nanj]]

Fixed via https://github.com/mozilla-services/merino-py/pull/286.

Firefox will fall back to the globe icon if hi-res icons (52x52 and beyond) can't be fetched from the target sites.

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Hi Nan!

I have verified this issue but it is still reproducible, the icons are still blurry on the latest Nightly 114.0a1 build (Build ID: 20230508094425).
Is there any server-related change that needs to be deployed so we can verify this?

Comment 5

[Nan Jiang [:nanj]]

Oh, sorry for forgetting to mention that the patch was merged but the new domain list (including images) would be generated by another backend task tomorrow. Let's verify this on Wednesday :)

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

No worries, I'll be back Wednesday.

Comment 7

[Nan Jiang [:nanj]]

LOL, thanks, Cosmin!

Comment 8

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Nightly 115.0a1 build (Build ID: 20230509215006), Firefox Beat 114.0b2 (Build ID: 20230509180058) and Firefox 113.0 (Build ID: 20230504192738) on Windows 10x64, macOS 13.1 and Linux Mint.

• The blurry Top Pick's favicons bug falls back to the globe icon.