1830453 - Firefox needs to be compiled with O2/O3 flag (depends on compiler) for better performance. Additionally LTO needs to enabled always.

I copy this from about:buildconfig page from the browser, additional it's look like that Windows build don't use key -O for Rust too? It may be this is an error in something else? Additionally, code don't have any flags for msvc compiler, but it definitely still uses for build and have dependences in the xul.dll and other parts of browser. And I don't understand why is the upx packer is still used for distribution?? The upx only increase memory footprint for any process and not do anything else. Oo

Build platform
target
x86_64-pc-mingw32
Build tools
Compiler Version Compiler flags
/builds/worker/fetches/clang/bin/clang-cl -Qunused-arguments -Xclang -std=gnu99 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml 15.0.5 -fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -Gy -Zc:inline -Gw
/builds/worker/fetches/clang/bin/clang-cl -Qunused-arguments -Xclang -std=c++17 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml 15.0.5 -fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -Gy -Zc:inline -Gw -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -O2 -Oy
/builds/worker/fetches/rustc/bin/rustc 1.67.0
Configure options

MOZ_AUTOMATION=1 --target=x86_64-pc-windows-msvc MOZILLA_OFFICIAL=1 --enable-update-channel=release MOZBUILD_STATE_PATH=/builds/worker/.mozbuild MOZ_FETCHES_DIR=/builds/worker/fetches WINSYSROOT=/builds/worker/fetches/vs CC=clang-cl CXX=clang-cl LINKER=lld-link ENABLE_CLANG_PLUGIN=1 --enable-profile-use=cross --with-pgo-profile-path=/builds/worker/fetches/merged.profdata --with-pgo-jarlog=/builds/worker/fetches/en-US.log MOZ_LTO=cross --enable-js-shell --enable-rust-simd --with-mozilla-api-keyfile=/builds/mozilla-desktop-geoloc-api.key --with-google-location-service-api-keyfile=/builds/gls-gapi.data --with-google-safebrowsing-api-keyfile=/builds/sb-gapi.data UPX=/builds/worker/fetches/upx-3.95-win64/upx.exe --enable-official-branding

Elle Solomina (she/her)

Assignee

Comment 3

•

2 years ago

Attached file Build configuration Windows — Details

Elle Solomina (she/her)

Assignee

Comment 4

•

2 years ago

Attached file Build config Windows — Details

Comment hidden (obsolete)

The problem is found here:

Windows build not use properly options at all:

<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Security-Policy" content="default-src 'none'; style-src chrome:; object-src 'none'" />
<meta charset="UTF-8">
<meta name="color-scheme" content="light dark">
<meta name="viewport" content="width=device-width; user-scalable=false;">
<title>Build Configuration</title>
<link rel="stylesheet" href="chrome://global/skin/in-content/info-pages.css" type="text/css">
<link rel="stylesheet" href="chrome://global/content/buildconfig.css" type="text/css">
</head>
<body>
<div class="container">
<h1>Build Configuration</h1>
<p>Please be aware that this page doesn't reflect all the options used to build Firefox.</p>
<h2>Source</h2>
<p>Built from <a href="https://hg.mozilla.org/releases/mozilla-release/rev/8141476bccc7d2e2468b740df03954d6ab212248">https://hg.mozilla.org/releases/mozilla-release/rev/8141476bccc7d2e2468b740df03954d6ab212248</a></p>
<h2>Build platform</h2>
<table class="build-platform-table">
<tbody>
<tr>
<th>target</th>
</tr>
<tr>
<td>x86_64-pc-mingw32</td>
</tr>
</tbody>
</table>
<h2>Build tools</h2>
<table>
<tbody>
<tr>
<th>Compiler</th>
<th>Version</th>
<th>Compiler flags</th>
</tr>
<tr>
<td>/builds/worker/fetches/clang/bin/clang-cl -Qunused-arguments -Xclang -std=gnu99 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml</td>
<td>15.0.5</td>
<td>-fcrash-diagnostics-dir=/builds/worker/artifacts -D_HAS_EXCEPTIONS=0 -Gy -Zc:inline -Gw</td>
</tr>
<tr>
<td>/builds/worker/fetches/clang/bin/clang-cl -Qunused-arguments -Xclang -std=c++17 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml</td>
<td>15.0.5</td>
<td>-fcrash-diagnostics-dir=/builds/worker/artifacts -TP -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -Gy -Zc:inline -Gw -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -O2 -Oy</td>
</tr>
<tr>
<td>/builds/worker/fetches/rustc/bin/rustc</td>
<td>1.68.0</td>
<td></td>
</tr>
</tbody>
</table>
<h2>Configure options</h2>
<p>MOZ_AUTOMATION=1 --target=x86_64-pc-windows-msvc MOZILLA_OFFICIAL=1 --enable-update-channel=release MOZBUILD_STATE_PATH=/builds/worker/.mozbuild MOZ_FETCHES_DIR=/builds/worker/fetches WINSYSROOT=/builds/worker/fetches/vs CC=clang-cl CXX=clang-cl LINKER=lld-link ENABLE_CLANG_PLUGIN=1 --enable-profile-use=cross --with-pgo-profile-path=/builds/worker/fetches/merged.profdata --with-pgo-jarlog=/builds/worker/fetches/en-US.log MOZ_LTO=cross --enable-js-shell --enable-rust-simd --with-mozilla-api-keyfile=/builds/mozilla-desktop-geoloc-api.key --with-google-location-service-api-keyfile=/builds/gls-gapi.data --with-google-safebrowsing-api-keyfile=/builds/sb-gapi.data UPX=/builds/worker/fetches/upx-3.95-win64/upx.exe --enable-official-branding</p>
</div>
</body>
</html>

But osX use additional options, include O3 and much more, including nortti and other.

<!DOCTYPE html>
<html><head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<meta http-equiv="Content-Security-Policy" content="default-src 'none'; style-src chrome:; object-src 'none'">
<meta charset="UTF-8">
<meta name="color-scheme" content="light dark">
<meta name="viewport" content="width=device-width; user-scalable=false;">
<title>Build Configuration</title>
<link rel="stylesheet" href="chrome://global/skin/in-content/info-pages.css" type="text/css">
<link rel="stylesheet" href="chrome://global/content/buildconfig.css" type="text/css">
</head>
<body>
<div class="container">
<h1>Build Configuration</h1>
<p>Please be aware that this page doesn't reflect all the options used to build Firefox.</p>
<h2>Source</h2>
<p>Built from <a href="https://hg.mozilla.org/releases/mozilla-release/rev/8141476bccc7d2e2468b740df03954d6ab212248">https://hg.mozilla.org/releases/mozilla-release/rev/8141476bccc7d2e2468b740df03954d6ab212248</a></p>
<h2>Build platform</h2>
<table class="build-platform-table">
<tbody>
<tr>
<th>target</th>
</tr>
<tr>
<td>x86_64-apple-darwin</td>
</tr>
</tbody>
</table>
<h2>Build tools</h2>
<table>
<tbody>
<tr>
<th>Compiler</th>
<th>Version</th>
<th>Compiler flags</th>
</tr>
<tr>
<td>/builds/worker/fetches/clang/bin/clang -isysroot
/builds/worker/fetches/MacOSX13.0.sdk -mmacosx-version-min=10.12
-Qunused-arguments -std=gnu99 --target=x86_64-apple-darwin</td>
<td>15.0.5</td>
<td>-fcrash-diagnostics-dir=/builds/worker/artifacts -fPIC -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe</td>
</tr>
<tr>
<td>/builds/worker/fetches/clang/bin/clang++ -isysroot
/builds/worker/fetches/MacOSX13.0.sdk -mmacosx-version-min=10.12
-stdlib=libc++ -Qunused-arguments -std=gnu++17
--target=x86_64-apple-darwin</td>
<td>15.0.5</td>
<td>-fno-sized-deallocation -fno-aligned-new
-fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC
-fno-rtti -ffunction-sections -fdata-sections -fno-exceptions
-fno-math-errno -pthread -pipe -gdwarf-4 -O3 -fno-omit-frame-pointer
-funwind-tables</td>
</tr>
<tr>
<td>/builds/worker/fetches/rustc/bin/rustc</td>
<td>1.68.0</td>
<td></td>
</tr>
</tbody>
</table>
<h2>Configure options</h2>
<p>MOZ_AUTOMATION=1 --target=x86_64-apple-darwin
MOZILLA_OFFICIAL=1 --enable-update-channel=release
MOZBUILD_STATE_PATH=/builds/worker/.mozbuild
MOZ_FETCHES_DIR=/builds/worker/fetches --enable-linker=ld64
--enable-clang-plugin --enable-profile-use=cross
--with-pgo-profile-path=/builds/worker/fetches/merged.profdata
--with-pgo-jarlog=/builds/worker/fetches/en-US.log MOZ_LTO=cross
--enable-js-shell --enable-rust-simd
--with-mozilla-api-keyfile=/builds/mozilla-desktop-geoloc-api.key
--with-google-location-service-api-keyfile=/builds/gls-gapi.data
--with-google-safebrowsing-api-keyfile=/builds/sb-gapi.data
DSYMUTIL=/builds/worker/fetches/clang/bin/dsymutil
MKFSHFS=/builds/worker/fetches/hfsplus/newfs_hfs
HFS_TOOL=/builds/worker/fetches/dmg/hfsplus --enable-official-branding</p>
<hr>
<p>Please be aware that this page doesn't reflect all the options used to build Firefox.</p>
<h2>Source</h2>
<p>Built from <a href="https://hg.mozilla.org/releases/mozilla-release/rev/8141476bccc7d2e2468b740df03954d6ab212248">https://hg.mozilla.org/releases/mozilla-release/rev/8141476bccc7d2e2468b740df03954d6ab212248</a></p>
<h2>Build platform</h2>
<table class="build-platform-table">
<tbody>
<tr>
<th>target</th>
</tr>
<tr>
<td>aarch64-apple-darwin</td>
</tr>
</tbody>
</table>
<h2>Build tools</h2>
<table>
<tbody>
<tr>
<th>Compiler</th>
<th>Version</th>
<th>Compiler flags</th>
</tr>
<tr>
<td>/builds/worker/fetches/clang/bin/clang -isysroot
/builds/worker/fetches/MacOSX13.0.sdk -mmacosx-version-min=11.0
-Qunused-arguments -std=gnu99 --target=aarch64-apple-darwin</td>
<td>15.0.5</td>
<td>-fcrash-diagnostics-dir=/builds/worker/artifacts
-mcpu=apple-m1 -fPIC -ffunction-sections -fdata-sections -fno-math-errno
-pthread -pipe</td>
</tr>
<tr>
<td>/builds/worker/fetches/clang/bin/clang++ -isysroot
/builds/worker/fetches/MacOSX13.0.sdk -mmacosx-version-min=11.0
-stdlib=libc++ -Qunused-arguments -std=gnu++17
--target=aarch64-apple-darwin</td>
<td>15.0.5</td>
<td>-fno-sized-deallocation -fno-aligned-new
-fcrash-diagnostics-dir=/builds/worker/artifacts -mcpu=apple-m1
-fno-exceptions -fPIC -fno-rtti -ffunction-sections -fdata-sections
-fno-exceptions -fno-math-errno -pthread -pipe -gdwarf-4 -O3
-fno-omit-frame-pointer -funwind-tables</td>
</tr>
<tr>
<td>/builds/worker/fetches/rustc/bin/rustc</td>
<td>1.68.0</td>
<td></td>
</tr>
</tbody>
</table>
<h2>Configure options</h2>
<p>MOZ_AUTOMATION=1 --target=aarch64-apple-darwin
MOZILLA_OFFICIAL=1 --enable-update-channel=release
MOZBUILD_STATE_PATH=/builds/worker/.mozbuild
MOZ_FETCHES_DIR=/builds/worker/fetches --enable-linker=ld64
--enable-clang-plugin --enable-profile-use=cross
--with-pgo-profile-path=/builds/worker/fetches/merged.profdata
--with-pgo-jarlog=/builds/worker/fetches/en-US.log MOZ_LTO=cross
--enable-js-shell --enable-rust-simd
--with-mozilla-api-keyfile=/builds/mozilla-desktop-geoloc-api.key
--with-google-location-service-api-keyfile=/builds/gls-gapi.data
--with-google-safebrowsing-api-keyfile=/builds/sb-gapi.data
DSYMUTIL=/builds/worker/fetches/clang/bin/dsymutil
MKFSHFS=/builds/worker/fetches/hfsplus/newfs_hfs
HFS_TOOL=/builds/worker/fetches/dmg/hfsplus --enable-official-branding</p>
</div>

</body></html>

Monica Chiorean

Comment 6

•

2 years ago

Marking as new so that development team can have a look at this enhancement. Thank you.

Status: UNCONFIRMED → NEW

Ever confirmed: true

Elle Solomina (she/her)

Assignee

Updated

•

8 months ago

Summary: Firefox needs to be compiled with O3 flag for better performance → Firefox needs to be compiled with Ox flag on Windows for better performance

Elle Solomina (she/her)

Assignee

Comment 7

•

8 months ago

[Tracking Requested - why for this release]:

Performance Impact: --- → ?

tracking-firefox131: --- → ?

tracking-firefox132: --- → ?

tracking-firefox133: --- → ?

tracking-firefox-esr115: --- → ?

tracking-firefox-esr128: --- → ?

tracking-thunderbird_esr115: --- → ?

tracking-thunderbird_esr128: --- → ?

Summary: Firefox needs to be compiled with Ox flag on Windows for better performance → Firefox needs to be compiled with Ox flag on Windows and O3 flag on Linux for better performance.

Version: Firefox 112 → unspecified

Elle Solomina (she/her)

Assignee

Updated

•

8 months ago

OS: Unspecified → All

Hardware: Unspecified → Desktop

Summary: Firefox needs to be compiled with Ox flag on Windows and O3 flag on Linux for better performance. → Firefox needs to be compiled with Ox flag on Windows and O3 flag on Linux for better performance. MacOS builds is already O3.

Elle Solomina (she/her)

Assignee

Updated

•

8 months ago

Summary: Firefox needs to be compiled with Ox flag on Windows and O3 flag on Linux for better performance. MacOS builds is already O3. → Firefox needs to be compiled with Ox flag on Windows and O3 flag on Linux for better performance. MacOS builds is already O3. Additionally LTO needs to enbled everywhere.

Donal Meehan [:dmeehan]

Updated

•

8 months ago

Performance Impact: ? → ---

tracking-firefox131: ? → ---

tracking-firefox132: ? → ---

tracking-firefox133: ? → ---

tracking-firefox-esr115: ? → ---

tracking-firefox-esr128: ? → ---

tracking-thunderbird_esr115: ? → ---

tracking-thunderbird_esr128: ? → ---

Elle Solomina (she/her)

Assignee

Updated

•

8 months ago

Summary: Firefox needs to be compiled with Ox flag on Windows and O3 flag on Linux for better performance. MacOS builds is already O3. Additionally LTO needs to enbled everywhere. → Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enbled always.

Elle Solomina (she/her)

Assignee

Comment 8

•

8 months ago

Well... I currently self tested the build for Windows only with clang-cl, and it has significant improvements in the binary sizes, performance of the browser (up to 2.5x in some of my use cases).

Elle Solomina (she/her)

Assignee

Updated

•

8 months ago

Summary: Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enbled always. → Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enabled always.

Elle Solomina (she/her)

Assignee

Comment 9

•

8 months ago

Attached file Bug 1830453 - Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enabled always. r=fdoty, — Details

Phabricator Automation

Updated

•

8 months ago

Assignee: nobody → a.rainman

Status: NEW → ASSIGNED

Elle Solomina (she/her)

Assignee

Updated

•

8 months ago

Duplicate of this bug: 1417048

Andrew McCreight [:mccr8]

Updated

•

8 months ago

Component: Performance Engineering → General

Product: Core → Firefox Build System

Elle Solomina (she/her)

Assignee

Comment 11

•

8 months ago

Attached file Bug 1830453 - Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enabled always. r=fdoty — Details

Elle Solomina (she/her)

Assignee

Updated

•

8 months ago

Summary: Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enabled always. → Firefox needs to be compiled with O2/O3 flag (depends on compiler) for better performance. Additionally LTO needs to enabled always.

Will

Comment 12

•

7 months ago

Apologies for the ping but is this one valid? I ask because I see the team is leaving no stone unturned to improve Speedometer score https://bugzilla.mozilla.org/show_bug.cgi?id=1800713

Elle Solomina (she/her)

Assignee

Comment 13

•

7 months ago

(In reply to Will from comment #12)

Apologies for the ping but is this one valid? I ask because I see the team is leaving no stone unturned to improve Speedometer score https://bugzilla.mozilla.org/show_bug.cgi?id=1800713

Yes, it is.

Will

Comment 14

•

7 months ago

(In reply to Elle Solomina (she/her) from comment #13)

(In reply to Will from comment #12)

Apologies for the ping but is this one valid? I ask because I see the team is leaving no stone unturned to improve Speedometer score https://bugzilla.mozilla.org/show_bug.cgi?id=1800713

Yes, it is.

That's fantastic. Sorry to be a bother but could you run the Speedometer 3 test a few times and tell us how much of an improvement you see?

Will

Comment 15

•

7 months ago

If this is just for Windows, there should be no concerns about RAM or disk space at this point. In late 2024 (or early 2025 by the time this would ship to production) the vast majority of Windows devices have more than enough RAM and disk space to justify using -O2/-O3. 15% of Firefox users have 4GB of RAM and that number is declining steadily https://data.firefox.com/dashboard/hardware#:~:text=The%20most%20popular%20memory%20sizes%20are%208GB%20and%2016GB%2C%20with%20almost%20one%2Dthird%20and%20one%2Dfifth%20of%20our%20Release%20users%2C%20respectively.

If this is also about the Android version of Firefox that's a bit more tricky because there's so many RAM and storage constrained devices out there that Google ships 2 different versions of Chrome. Is Firefox able to do that on Android? https://blog.chromium.org/2024/12/doubling-speedometer-scores-android.html#:~:text=The%20Android%20device,generate%20the%20orderfile.

Elle Solomina (she/her)

Assignee

Comment 16

•

1 month ago

(In reply to Will from comment #14)

(In reply to Elle Solomina (she/her) from comment #13)

(In reply to Will from comment #12)

Apologies for the ping but is this one valid? I ask because I see the team is leaving no stone unturned to improve Speedometer score https://bugzilla.mozilla.org/show_bug.cgi?id=1800713

Yes, it is.

That's fantastic. Sorry to be a bother but could you run the Speedometer 3 test a few times and tell us how much of an improvement you see?

Now I'm here again! :) But currently I can't bootstrap the source to test https://bugzilla.mozilla.org/show_bug.cgi?id=1967567

Elle Solomina (she/her)

Assignee

Comment 17

•

1 month ago

Yeap, it's work!

Status: ASSIGNED → RESOLVED

Closed: 1 month ago

Resolution: --- → WORKSFORME

Elle Solomina (she/her)

Assignee

Updated

•

1 month ago

Status: RESOLVED → REOPENED

Resolution: WORKSFORME → ---

Will

Comment 18

•

1 month ago

Be sure to use Speedometer 3.1 , which is the newest version

Build configuration Windows 2 years ago Elle Solomina (she/her) 3.07 KB, text/plain		Details
Build config Windows 2 years ago Elle Solomina (she/her) 3.07 KB, text/plain		Details
Bug 1830453 - Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enabled always. r=fdoty, 8 months ago Elle Solomina (she/her) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1830453 - Firefox needs to be compiled with Ox flag on Windows and O3 flag on other platforms for better performance. MacOS builds is already O3. Additionally LTO needs to enabled always. r=fdoty 8 months ago Elle Solomina (she/her) 48 bytes, text/x-phabricator-request		Details \| Review