Closed
Bug 183055
Opened 22 years ago
Closed 22 years ago
Remove unnecessary "AppendStringToMenulist()" method from Composer JS
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.3beta
People
(Reporter: cmanske, Assigned: cmanske)
References
Details
Attachments
(1 file, 2 obsolete files)
|
11.36 KB,
patch
|
neil
:
review+
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
AppendStringToMenulist() is only used in a couple of dialogs and should be
replaced with the menulist "appendItem()" method.
|
Assignee | |
Comment 1•22 years ago
|
||
Just some simple dialog cleanup to remove bloat and increase efficiency
|
|
Assignee | |
Updated•22 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [FIX IN HAND]need r=,sr=
Target Milestone: --- → mozilla1.3alpha
|
|
Assignee | |
Updated•22 years ago
|
Attachment #107924 -
Flags: superreview?(alecf)
Attachment #107924 -
Flags: review?(neil)
|
|
||
Comment 2•22 years ago
|
||
Comment on attachment 107924 [details] [diff] [review]
fix v1
sr=me
Attachment #107924 -
Flags: superreview?(alecf) → superreview+
|
||
Updated•22 years ago
|
Attachment #107924 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 3•22 years ago
|
||
checked into 1.3a trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Whiteboard: [FIX IN HAND]need r=,sr=
|
||
Comment 4•22 years ago
|
||
This code won't work; if you don't want the version in bug 164033 you need to
check in the patch to bug 118038 first.
|
|
Assignee | |
Comment 5•22 years ago
|
||
Doh! Forgot about that dependency. I have too many of Neil's great patches in
my my tree :)
Status: REOPENED → ASSIGNED
|
|
Assignee | |
Comment 6•22 years ago
|
||
After having to back out changes to make menulists work w/o the fix to bug
118038,
this restores the orginal changes.
Attachment #107924 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Whiteboard: [FIX IN HAND] need sr=
Target Milestone: mozilla1.3alpha → mozilla1.3beta
|
|
Assignee | |
Updated•22 years ago
|
Attachment #108879 -
Flags: superreview?(dveditz)
Attachment #108879 -
Flags: review?(neil)
|
|
||
Comment 7•22 years ago
|
||
Comment on attachment 108879 [details] [diff] [review]
fix v2
Is it worth inlining ClearMenulist?
Attachment #108879 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 8•22 years ago
|
||
More simplification to eliminate need for "ClearMenuList()" method.
Attachment #108879 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•22 years ago
|
Attachment #108879 -
Flags: superreview?(dveditz)
Attachment #108879 -
Flags: review+
|
|
Assignee | |
Updated•22 years ago
|
Attachment #108902 -
Flags: superreview?(dveditz)
Attachment #108902 -
Flags: review?(neil)
|
|
||
Updated•22 years ago
|
Attachment #108902 -
Flags: review?(neil) → review+
|
|
||
Comment 9•22 years ago
|
||
Comment on attachment 108902 [details] [diff] [review]
fix v3
sr=me
Attachment #108902 -
Flags: superreview?(dveditz) → superreview+
|
|
Assignee | |
Comment 10•22 years ago
|
||
Checked into 1.3b trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Whiteboard: [FIX IN HAND] need sr=
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•