1830605 - Regression: Unix-style slashes in file paths failing on Windows, causing addon errors

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[pallaswept]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:114.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

Updated nightly.

Actual results:

KeepassXC cannot connect. Following their troubleshooting steps at https://github.com/keepassxreboot/keepassxc-browser/wiki/Troubleshooting-guide, I notice that keepassxc-proxy.exe does not load. Starting it manually did not help. All other configuration is correct as per that guide.

Expected results:

KeepassXC should keep working like it does in earlier builds. I rolled back to an older build and it works. This one works https://ftp.mozilla.org/pub/firefox/nightly/2023/04/2023-04-25-15-43-13-mozilla-central-l10n/firefox-114.0a1.en-GB.win64.installer.exe. Unsure of any later builds. Others have also reported this not working in latest nightly builds, on the keepassxc-browser github issues at https://github.com/keepassxreboot/keepassxc-browser/issues?q=is%3Aissue

Comment 1

[pallaswept]

One of the bug reports at the addon's github (https://github.com/keepassxreboot/keepassxc-browser/issues/1905) has a root cause for this.

The registry key "HKEY_CURRENT_USER\SOFTWARE\Mozilla\NativeMessagingHosts\org.keepassxc.keepassxc_browser" contains a path to a file. That path contains forward-slashes, unix-style. ie it will be set to "C:/Users/username/AppData/Local/KeePassXC/org.keepassxc.keepassxc_browser_tor-browser.json". Changing those slashes to backslashes, windows-style, ie "C:\Users\username\AppData\Local\KeePassXC\org.keepassxc.keepassxc_browser_tor-browser.json" makes this issue go away and the addon works again.

Not sure if this new sensitivity to path parsing is intentional or not, but hopefully this is helpful information.

Comment 2

[pallaswept]

I have renamed this bug report to reflect the root cause as this will be effecting other addons as well.

Comment 4

[Rob Wu [:robwu]]

Not too long ago there was a similar regression caused by switching from osfile to PathUtils, in bug 1791788... I'll look into a patch.

For anyone interested in digging deeper, the KeepassXC extension registers its native manifest at https://github.com/keepassxreboot/keepassxc/blob/2.7.4/src/browser/NativeMessageInstaller.cpp, specifically:

• native manifest creation: https://github.com/keepassxreboot/keepassxc/blob/2.7.4/src/browser/NativeMessageInstaller.cpp#L301-L338
• path generated at https://github.com/keepassxreboot/keepassxc/blob/2.7.4/src/browser/NativeMessageInstaller.cpp#L274-L299

Comment 5

[Rob Wu [:robwu]]

Attachment: Bug 1830605 - Normalize path to native messaging manifest on Windows

Comment 6

[Rob Wu [:robwu]]

Linking bug 1791788 for visibility. Both bugs were triggered by the same kind of refactoring, and in both cases the behaviors expected by users were not covered by unit tests (now they are).

Comment 7

[pallaswept]

Thanks so much for your help, Rob, Robert, Tom, and anyone I missed.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1772932

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ca2ab32ea09
Normalize path to native messaging manifest on Windows r=extension-reviewers,mixedpuppy

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for causing xpc failures on test_native_manifests.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=1ca2ab32ea0988aa4877fa035975267728ea7173&searchStr=xpc&tochange=4d974b2e7e4e0c91949ec4208fce2f65ef92f12c&selectedTaskRun=X7adMXU6QgeFm5ehq5g3OA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=414284938&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/4d974b2e7e4e0c91949ec4208fce2f65ef92f12c

Comment 11

[Rob Wu [:robwu]]

Small error in the test. I'll fix up and reland.
I do wonder what the purpose of ./mach try is if it can't even catch a failure from the test that was modified in the same patch...

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56b6297136e9
Normalize path to native messaging manifest on Windows r=extension-reviewers,mixedpuppy

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/56b6297136e9