Closed Bug 1830675 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 39770 - Add tabindex to popover buttons

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39770 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39770
Details from upstream follow.

Rob Buis <rbuis@igalia.com> wrote:

Add tabindex to popover buttons

Add tabindex to popover buttons in order to make them focusable on macOS and pass these tests.

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Try push failed: decision task Ujw7oiUqRx2Am9DUX7gwaQ returned error

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 3[GitHub] 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
PASS : 1[GitHub] 7[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 8[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug]
FAIL : 33[GitHub] 47[Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug] 48[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
ERROR : 1
NOTRUN: 20

Chrome

OK : 3
PASS : 17
FAIL : 12
ERROR : 1

Safari

OK : 3
PASS : 1
FAIL : 33
ERROR : 1
NOTRUN: 21

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/popovers/popover-focus-2.html [wpt.fyi]
    • Popover focus navigation: FAIL (Chrome: FAIL, Safari: FAIL)
    • Circular reference tab navigation: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover focus returns when popover is hidden by invoker: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover focus only returns to invoker when focus is within the popover: FAIL (Chrome: FAIL, Safari: FAIL)
  • /html/semantics/popovers/popover-focus.html [wpt.fyi]
    • Popover focus test: default behavior - popover is not focused: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: default behavior - popover is not focused: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover focus test: autofocus popover: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: autofocus popover: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover corner cases test: autofocus popover: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover focus test: autofocus empty popover: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: autofocus empty popover: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover corner cases test: autofocus empty popover: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover focus test: autofocus popover with button: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: autofocus popover with button: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover corner cases test: autofocus popover with button: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover focus test: autofocus child: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: autofocus child: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover corner cases test: autofocus child: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover focus test: autofocus on tabindex=0 element: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: autofocus on tabindex=0 element: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover corner cases test: autofocus on tabindex=0 element: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover focus test: autofocus multiple children: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: autofocus multiple children: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover corner cases test: autofocus multiple children: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover focus test: autofocus popover and multiple autofocus children: FAIL (Chrome: FAIL, Safari: FAIL)
    • Popover button click focus test: autofocus popover and multiple autofocus children: FAIL (Chrome: PASS, Safari: FAIL)
    • Popover corner cases test: autofocus popover and multiple autofocus children: FAIL (Chrome: PASS, Safari: FAIL)
  • /html/semantics/popovers/popover-light-dismiss.html [wpt.fyi]: ERROR [GitHub], OK [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: ERROR, Safari: ERROR)
    • Clicking outside a popover will dismiss the popover: FAIL (Safari: FAIL)
    • Canceling pointer events should not keep clicks from light dismissing popovers: FAIL (Safari: FAIL)
    • Clicking inside a popover does not close that popover: FAIL (Safari: FAIL)
    • Popovers close on pointerup, not pointerdown: FAIL (Safari: FAIL)
    • Synthetic events can't close popovers: FAIL (Safari: FAIL)
    • Moving focus outside the popover should not dismiss the popover: NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Safari: NOTRUN)
    • Clicking inside a child popover shouldn't close either popover: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Clicking inside a parent popover should close child popover: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Clicking on invoking element, after using it for activation, shouldn't close its popover: NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Safari: NOTRUN)
    • Clicking on invoking element, after using it for activation, shouldn't close its popover (nested case): FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Clicking on invoking element, after using it for activation, shouldn't close its popover (nested case, not used for invocation): FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Clicking on invoking element, even if it wasn't used for activation, shouldn't close its popover: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Clicking on popovertarget element, even if it wasn't used for activation, should hide it exactly once: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Clicking on anchor element (that isn't an invoking element) shouldn't prevent its popover from being closed: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Dragging from an open popover outside an open popover should leave the popover open: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • A popover inside an invoking element doesn't participate in that invoker's ancestor chain: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • An invoking element that was not used to invoke the popover is not part of the ancestor chain: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Scrolling within a popover should not close the popover: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug] (Safari: NOTRUN)
    • Clicking outside a shadow DOM popover should close that popover: FAIL (Safari: NOTRUN)
    • Moving focus back to the anchor element should not dismiss the popover: NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Safari: NOTRUN)
    • Ensure circular/convoluted ancestral relationships are functional: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Ensure circular/convoluted ancestral relationships are functional, with a direct showPopover(): FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Hide the target popover during "hide all popovers until": FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Show a sibling popover during "hide all popovers until": FAIL [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], NOTRUN [GitHub] (Safari: NOTRUN)
    • Show an unrelated popover during "hide popover": NOTRUN [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Safari: NOTRUN)
    • Light dismiss of mixed popover types including hints: NOTRUN
  • /html/semantics/popovers/popover-not-keyboard-focusable.html [wpt.fyi]
    • Popover should not be keyboard focusable: FAIL [GitHub], PASS [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0e5b9865bf9 [wpt PR 39770] - Add tabindex to popover buttons, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e0e5b9865bf9

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.