1830732 - Pressing Cmd+C in the address bar sometimes copies about:blank when the page hasn't fully loaded even though the full URL is selected

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Markus Stange [:mstange]]

This happened to me for the second time just now, where I pasted about:blank in a chat instead of the URL I meant to paste.

Steps to reproduce:

1. Click a link which opens in a new foreground tab and which takes a second to load. For example, a link to a google doc from gmail.
2. Press Cmd+L and Cmd+C.

Expected results:
The URL in the URL bar should be copied.

Expected results:
The string "about:blank" is copied instead, unless you wait long enough for the two redirects to complete.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:adw, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Stephanie Cunnane [:scunnane]]

We are able to reproduce this using fakeresponse.com. This needs investigation. It may be a timing issue where we are asking browser for the current URI, which is still about:blank at that point.

Here's a link to relevant code: https://searchfox.org/mozilla-central/rev/81f368dab93fff035ce7fcc376e16990e89dd5ec/browser/components/urlbar/UrlbarInput.sys.mjs#2478-2479

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1830732: If there is a loading page in _blank target, copy its URL

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 610357

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff91f2868c64
If there is a loading page in _blank target, copy its URL r=adw

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/ff91f2868c64

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9360158 [details]
Bug 1830732: If there is a loading page in _blank target, copy its URL

Beta/Release Uplift Approval Request

• User impact if declined: If user copies the url of urlbar before finishing loading the page opened in _blank target, the content will be wrong ("about:blank " test will be copied).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The main changes are some lines, and they affect only the copying behavior on the urlbar.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 9

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9360158 [details]
Bug 1830732: If there is a loading page in _blank target, copy its URL

Approved for 120.0b5

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/44ce5a574a04