1830740 - Add a flag to enable/disable fenix in mach try perf

Status: RESOLVED FIXED

(Testing :: Performance, defect, P2)

Description

[Greg Mierzwinski [:sparky]]

Currently Fenix runs the nightly build from the firefox-android branch on both the base, and the new commit which can confuse people as there is nothing that shows this. We should add a --fenix flag to enable/disable fenix so that it's only triggered on android runs when it's explicitly requested. This will also force people to read the help message that will have this information.

We should also add this information to the FAQ in the mach-try-perf docs.

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1830740 - Add flag to enable fenix in mach-try-perf. r?#perftest,aglavic

This patch adds a flag to enable fenix in mach try perf. Currently, it's enabled by default however it's not clear that it uses the same build in the base/new try runs. This patch adds some documentation to the FAQ for this, as well as some information in the --help message.

At the same time, this patch adds some code to handle apps requested with --apps better. Previously, for example, if fenix was requested, the catch-all/base category would capture geckoview tasks as well, but it wasn't clear to the user that this would happen. Now, if an app is requested, that is the only app that will be scheduled, assuming the "default" app has a negation. The notion of a "default" app is also introduced here for any app that has no restriction method defined.

Finally, some extra changes are made to the tests for the fzf side effects to make it clear that the number of side effects must be greater than or equal to the number of fzf calls. This should prevent others from having to determine why their tests are failing on a seemingly unrelated change as the error message we receive is very unclear when this occurs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5a30ad398a0
Add flag to enable fenix in mach-try-perf. r=aglavic,perftest-reviewers

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f5a30ad398a0