Closed Bug 1830808 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39795 - [GridNG] Correctly account for baselines within subgrids.

Categories

(Core :: Layout: Grid, task, P4)

Product:
Core
Component:
Layout: Grid
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
116 Branch
Tracking Flags:
Tracking Status
firefox116 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39795 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39795
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[GridNG] Correctly account for baselines within subgrids.

This patch does several inter-connected things related to baselines.

  1. Account for the additional subgrid margin in contribution size.
  2. Account for the additional subgrid margin for baseline calculation.
  3. Recreate a subgrid baselines within CompleteTrackSizingAlgorithm.
  4. Within CreateSubgridTrackCollection correctly adjust inherited
    baselines for margin/border/scrollbar/padding/gutter.

Bug: 618969
Change-Id: I7697538b30eb29d04118b1065dcebdb1927c1519

Reviewed-on: https://chromium-review.googlesource.com/4496872
WPT-Export-Revision: de5f9ebb1cea8d904385e8dadb808209ebdf2e60

Component: web-platform-tests → Layout: Grid
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/727f8568546f [wpt PR 39795] - [GridNG] Correctly account for baselines within subgrids., a=testonly https://hg.mozilla.org/integration/autoland/rev/28747851836f [wpt PR 39795] - Update wpt metadata, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/727f8568546f
https://hg.mozilla.org/mozilla-central/rev/28747851836f

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox116: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 116 Branch
You need to log in before you can comment on or make changes to this bug.