1830850 - Annotations popups and icons must have a style for HCM

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P3)

Description

[Calixte Denizet (:calixte)]

Attachment: annotation-fileattachment.pdf

STR:

• switch to HCM
• open the attached pdf
• click on the pin

The popup isn't clearly visible:

• there is no border
• the background should probably be in a different color

The icon for the pin isn't really visible.

Comment 1

[Jonas Jenwald [:Snuffleupagus]]

(In reply to Calixte Denizet (:calixte) from comment #0)

The icon for the pin isn't really visible.

Please note that this icon is actually specified by the PDF document itself, via the /AP dictionary of the annotation.

Comment 2

[Calixte Denizet (:calixte)]

Attachment: annotation-link-text-popup.pdf

That's true and it means that we must apply the filter to it when it's drawn.
I thought it was an icon we embed.
Anyway we should have one for the hcm case: right now, the icon isn't drawn at all (see annotation-link-text-popup.pdf) or draw it with a filter.

Comment 3

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Apply HCM filters on annotations which have their own canvas (bug 1830850) (#16380)

Comment 4

[Calixte Denizet (:calixte)]

The pop-up hasn't been done for the moment, hence I reopen this bug.

Comment 5

[Anna Yeddi [:ayeddi]]

Looks to me like an a11y-s3 - the note appears as a custom tooltip, so this element is:

1. missing border that should use CanvasText. The text and the background appear to be using proper Canvas colors.
2. On the second example, annotation-link-text-popup.pdf, The image mark (sticker icon) itself now uses static/Canvas+CanvasText colors. In the stable 113 and 114.0.1 releases the icon that has the tooltip/note attached is created using ButtonFace+ButtonText color pair which is a good thing, IMO, as it signals to the user that it is actionable and they can hover over it. But Fx 115 uses static Canvas+CanvasText colors for it, which does miss the point of the image control.
3. The image mark does not have a hover HCM styling by itself, but the tooltip with the note appears on hover so I’d say it’s not a blocker issue. Expected hover styles for regular HCM button can be found in the Acorns' Components > Button > States > Hover section

Comment 6

[BMO Github Automation]

Attachment: [mozilla/pdf.js] Improve highlightments and popups in HCM (bug 1830850) (#16593)

Comment 7

[Daniel Bodea [:danibodea]]

The mentioned changes have been introduced in 3 steps: in branch 115 the link hover effect as a different background color, in branch 116 the tooltip border, in branch 117 the icons hover effect and the correct color for the link hover effect. The tooltip's background color remains the same as the page's background color, but I deem it unnecessary considering the border is visible enough.
Based on the above, I consider branches 117 and 118 as verified (Nightly v118.0a1 and Beta v117.0b2) in Windows 10 with 4 different HCM profiles.