Closed Bug 1830909 Opened 1 year ago Closed 8 months ago

Implement <hr>-in-<select>

Categories

(Core :: DOM: Forms, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
122 Branch
Tracking Status
relnote-firefox --- 122+
firefox122 --- fixed

People

(Reporter: annevk, Assigned: canadahonk)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, parity-chrome, parity-safari)

Attachments

(1 file)

This requires both HTML parser changes and some <select> rendering changes.

HTML PR: https://github.com/whatwg/html/pull/9124.

Keywords: dev-doc-needed

MDN Docs work can be tracked in https://github.com/mdn/content/issues/26536

The Safari 17 beta release notes list this.

Updated HTML parser to allow <hr> in <select>.
Also updated internal toolkit UI for <select> dropdown to create
menuseperators from hrs.

WIP. Todo:

  • XUL styling
  • Testing (WPT/HTML5Lib?)
Attachment #9354778 - Attachment description: WIP: Bug 1830909 - Implement <hr> in <select> → Bug 1830909 - Implement <hr> in <select>
Assignee: nobody → oj
Status: NEW → ASSIGNED
Blocks: html
Pushed by omedhurst@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f56003f45cc6
Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish

Backed out for causing bc failures on browser_selectpopup_colors.js

Backout link

Push with failures

Failure log

Flags: needinfo?(omedhurst)

Fixed, sorry. I'll reland later today.

Flags: needinfo?(omedhurst)
Pushed by omedhurst@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd4895b622d0
Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch

:canadahonk could you consider nominating this for a release note? (Process info)

Flags: needinfo?(omedhurst)

Release Note Request (optional, but appreciated)
[Why is this notable]: New HTML feature
[Affects Firefox for Android]: Somewhat, it is parsed correctly but does not render separators in the select menu.
[Suggested wording]: <hr>-in-<select> is now supported, allowing websites to easily use separators inside a <select> element.
[Links (documentation, blog post, etc)]:

relnote-firefox: --- → ?
Flags: needinfo?(omedhurst)

Thanks, added to the Fx122 nightly release notes, please allow 30 mins for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes.

Did we have a bug for the followup work for GeckoView to display the separator?

Flags: needinfo?(annevk)
Flags: needinfo?(annevk) → needinfo?(omedhurst)

Yes, see Bug 1867045

Flags: needinfo?(omedhurst)
See Also: → 1867045

Associated MDN content PRs

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: