1830909 - Implement <hr>-in-<select>

Status: RESOLVED FIXED

(Core :: DOM: Forms, enhancement)

Description

[Anne (:annevk)]

This requires both HTML parser changes and some <select> rendering changes.

HTML PR: https://github.com/whatwg/html/pull/9124.

Comment 1

[Hamish Willee]

MDN Docs work can be tracked in https://github.com/mdn/content/issues/26536

Comment 2

[Thomas Wisniewski [:twisniewski]]

The Safari 17 beta release notes list this.

Comment 3

[Oliver Medhurst [:canadahonk]]

Attachment: Bug 1830909 - Implement <hr> in <select>

Updated HTML parser to allow <hr> in <select>.
Also updated internal toolkit UI for <select> dropdown to create
menuseperators from hrs.

WIP. Todo:

• XUL styling
• Testing (WPT/HTML5Lib?)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f56003f45cc6
Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish

Comment 5

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_selectpopup_colors.js

Backout link

Push with failures

Failure log

Comment 6

[Oliver Medhurst [:canadahonk]]

Fixed, sorry. I'll reland later today.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd4895b622d0
Implement <hr> in <select> r=hsivonen,emilio,geckoview-reviewers,desktop-theme-reviewers,Jamie,owlish

Comment 8

[Oliver Medhurst [:canadahonk]]

Standards position: https://github.com/mozilla/standards-positions/issues/887
Intent to prototype and ship: https://groups.google.com/a/mozilla.org/g/dev-platform/c/hQExM12Wzf0

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dd4895b622d0

Comment 10

[Donal Meehan [:dmeehan]]

:canadahonk could you consider nominating this for a release note? (Process info)

Comment 11

[Oliver Medhurst [:canadahonk]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New HTML feature
[Affects Firefox for Android]: Somewhat, it is parsed correctly but does not render separators in the select menu.
[Suggested wording]: <hr>-in-<select> is now supported, allowing websites to easily use separators inside a <select> element.
[Links (documentation, blog post, etc)]:

• https://developer.chrome.com/blog/hr-in-select/
• https://github.com/whatwg/html/pull/9124

Comment 12

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx122 nightly release notes, please allow 30 mins for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx122 release notes.

Comment 13

[Tom S]

Did we have a bug for the followup work for GeckoView to display the separator?

Comment 14

[Oliver Medhurst [:canadahonk]]

Yes, see Bug 1867045

Comment 15

[Dave Letorey]

Associated MDN content PRs

• Content PR
• Release note PR

Comment 16

[Henri Sivonen (:hsivonen)]

https://github.com/validator/htmlparser/commit/85efc021aadb95e0e6df0bb025e67b8d2109a883