1830918 - Provide a mechanism to disable the forcing of the tcp send buffer size on http/2 uploads

Status: RESOLVED FIXED

(Core :: Networking: HTTP, task, P2)

Description

[Andrew Creskey [:acreskey]]

In Bug 1596576 we investigated and determined that our http/2 upload speed was limited by our capping of the tcp send buffer to 128 KB

In this bug we will introduce a mechanism to disable that capping.

Comment 1

[Andrew Creskey [:acreskey]]

Attachment: Bug 1830918 - Provide a mechanism to disable the forcing of the tcp send buffer size on http/2 uploads r=#necko-reviewers

In Bug 1596576 we will disable by default the forcing of tcp send buffer sizes on http/2 uploads.
This provides a mechanism for users to test early.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47909f2d0ba7
Provide a mechanism to disable the forcing of the tcp send buffer size on http/2 uploads r=necko-reviewers,valentin

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 47909f2d0ba7 (Bug 1830918) for causing bustage in ttp2StreamBase.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=A5HkyaTdRLiWvObC88xbwQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=47909f2d0ba7e7d2b5be2821b721fe371e482060&searchStr=linux%2Cx64%2Cplain%2Cbuild-linux64-hybrid%2Fplain%2Cbp-hybrid

Log: https://treeherder.mozilla.org/logviewer?job_id=414502561&repo=autoland&lineNumber=50784

Backout: https://hg.mozilla.org/integration/autoland/rev/57b92e69fc6f57bca1c3bef6dc20385b6660f33b

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc6f54b9aa3e
Provide a mechanism to disable the forcing of the tcp send buffer size on http/2 uploads r=necko-reviewers,valentin

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cc6f54b9aa3e