Closed
Bug 1830925
Opened 2 years ago
Closed 2 years ago
PopupNotifications should use lazy pref getter for security.notification_enable_delay
Categories
(Toolkit Graveyard :: Notifications and Alerts, task)
Toolkit Graveyard
Notifications and Alerts
Tracking
(firefox115 fixed)
RESOLVED
FIXED
115 Branch
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: emz, Assigned: abhishekmadan, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
The delay is currently only read on construction of PopupNotifications which means it can't update if the pref is changed during runtime.
Pref is currently assigned to a variable here: https://searchfox.org/mozilla-central/rev/3563da061ca2b32f7f77f5f68088dbf9b5332a9f/toolkit/modules/PopupNotifications.sys.mjs#241
It should use a lazy preference getter instead. Example: https://searchfox.org/mozilla-central/rev/3563da061ca2b32f7f77f5f68088dbf9b5332a9f/browser/actors/AboutNewTabChild.sys.mjs#21-26
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → amadan
|
Reporter | |
Updated•2 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e61eeb8e79d9
Added Lazy Pref Getter to allow for updates for security delay without having to restart browser. r=pbz
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
|
||
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•