1830937 - Make debugging APIs available on Android

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, defect, P1)

Description

[Beatriz Rizental [:brizental]]

I mean available from the code, not the activity. I can't test with the activity when adding Glean to a service... Or I don't know how to. Either way that would be convenient.

Comment 1

[Travis Long [:travis_]]

This would entail making some internal functions public:

https://github.com/mozilla/glean/blob/main/glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt#L481
https://github.com/mozilla/glean/blob/main/glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt#L424
And likely add a function for submitting pings, since submitPingByName requires a reason and it may be a bit much to ask the consumer to get this right.

Another option would be to create a new debug activity that can launch a service. Instead of this: https://github.com/mozilla/glean/blob/306fb0b3d4783360768aaac852ba734945a57cd1/glean-core/android/src/main/java/mozilla/telemetry/glean/debug/GleanDebugActivity.kt#L157, we would instead use this: https://developer.android.com/reference/android/content/Context.html#startService(android.content.Intent) to launch the service.

Comment 2

[Beatriz Rizental [:brizental]]

FWIW, in my use case I would be happy with just setLogPings and setDebugViewTag being public. Submit ping is not something I am missing at the moment.

Comment 3

[BMO Github Automation]

Attachment: [mozilla/glean] Bug 1830937 - Make `setLogPings` and `setDebugViewTag` public for And… (#2463)

Comment 4

[Jan-Erik Rediger [:janerik]]

badboy merged PR #2463: "Bug 1830937 - Make setLogPings and setDebugViewTag public for Android" in b45cb19.