1830986 - Improve performance of inner/outerHTML getters.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

One thing that stands out of the profiles in bug 1827132 are a ton of string allocations and attribute lookups.

Those seem optimizable rather easily, unless I'm missing something.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1830986 - Avoid a bunch of allocations in innerHTML / outerHTML getter. r=smaug!

One thing that stands out of the profiles in bug 1827132 are a ton of
allocations and attribute lookups.

While the root cause of that performance issue is likely to be a
DOMSubtreeModified event that Chrome doesn't fire or so, those are
rather easy to optimize and might be more generally useful.

I removed handling of <br type="">, because editor no longer uses it.
Maybe we can also remove some of the other of the prefixed attribute
shenanigans.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1830986 - Remove prefixed-attr-handling in node serialization. r=smaug

I think nodes that use these are really native-anonymous largely. So
this should be fine, but try is acting up today so if there's any test
failure we can re-evaluate / move to a separate bug as needed.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1830986 - Minor StringBuilder clean-ups. r=smaug

Depends on D176957

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1830986 - Make a more precise decision on the StringBuilder unit size. r=smaug

Depends on D177000

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2edf3ce20ce
Avoid a bunch of allocations in innerHTML / outerHTML getter. r=smaug
https://hg.mozilla.org/integration/autoland/rev/2319731dcff2
Minor StringBuilder clean-ups. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f56cd69dbabd
Make a more precise decision on the StringBuilder unit size. r=smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7820ebaff373
Fix 32-bit builds.

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c2edf3ce20ce
https://hg.mozilla.org/mozilla-central/rev/2319731dcff2
https://hg.mozilla.org/mozilla-central/rev/f56cd69dbabd
https://hg.mozilla.org/mozilla-central/rev/7820ebaff373