Closed Bug 1830992 Opened 3 years ago Closed 3 years ago

Replace update_rnp.sh with a `mach vendor` config

Categories

(MailNews Core :: Build Config, task)

task

Tracking

(thunderbird_esr102 wontfix)

RESOLVED FIXED
115 Branch
Tracking Status
thunderbird_esr102 --- wontfix

People

(Reporter: rjl, Assigned: rjl)

References

Details

Attachments

(2 files)

mach vendor is how Firefox handles updates to vendored third party code in mozilla-central. With RNP 0.17, I expect that the update_rnp.sh script will break yet again. Time to switch.

mach vendor is not perfect, but it's better than a shoddy bash script.

Summary: Replace update_rnp.sh with a `mach vendor` → Replace update_rnp.sh with a `mach vendor` config
Depends on: 1831003

Instead of generating a version.h file for librnp in advance, generate it
at build time. This will result in RNP_VERSION_FULL having less information
than previously - no timestamp and no git revision hash. Since Thunderbird
generally sticks to release versions now that RNP is stable, this should not
be a big problem.

If MZLA does apply patches to RNP, version.txt should be updated accordingly
so that the patch is reflected in version strings.

Requires patches in bug 1831682 on m-c.

Depends on: 1831682
No longer depends on: 1831682
Assignee: nobody → rob
Attachment #9331961 - Attachment description: WIP: Bug 1830992 - Update rnp build code to process version.h at build time. → Bug 1830992 - Update rnp build code to process version.h at build time. r=#thunderbird-build-system-reviewers,kaie
Status: NEW → ASSIGNED
Attachment #9331962 - Attachment description: WIP: Bug 1830992 - Add moz.yaml file to vendor RNP source code. r=kaie → Bug 1830992 - Add moz.yaml file to vendor RNP source code. r=kaie
Target Milestone: --- → 115 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5add237de82f
Update rnp build code to process version.h at build time. r=kaie
https://hg.mozilla.org/comm-central/rev/1014b63485bd
Add moz.yaml file to vendor RNP source code. r=kaie

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: