1831002 - Print dialog number-field spinbuttons have repeated up/down arrows (for "Copies", "Scale", and "Custom Margins")

Status: VERIFIED FIXED

(Toolkit :: Printing, defect)

Description

[Daniel Holbert [:dholbert]]

STR:

1. Ctrl+P to print some document
2. Click "More Settings", and under "Scale", choose the radio-button for the numeric 100 scale.
3. Look at the up/downarrow at the right edge of that box.

ACTUAL RESULTS:
The up/down arrows are repeated horizontally.

EXPECTED RESULTS:
No such repeating.

Note: this is similar to what was described in bug 1830619, except bug 1830619 was Thunderbird-specific.

It looks like the arrows are drawn via this CSS rule:
https://searchfox.org/mozilla-central/rev/3563da061ca2b32f7f77f5f68088dbf9b5332a9f/toolkit/components/printing/content/print.css#271-283

If I add background-repeat: no-repeat, that seems to fix this.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot with patch

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1831002: Avoid repeated arrows on spin-buttons in print dialog number fields. r?emilio,mstriemer

Comment 4

[Daniel Holbert [:dholbert]]

mozregression says this is a regression from bug 1828689, not too surprisingly. Marked as-such & set unaffected/affected statuses accordingly. It looks like we were just inadvertently depending on forms.css giving us background-repeat: no-repeat; by default for these spin buttons, when setting up our own custom background image in this dialog. (And that part of forms.css is now gone, as of bug 1828689.)

Comment 5

[Daniel Holbert [:dholbert]]

Fortunately it looks like this is the only place where we have a .css file that styles these pseudo-elements (besides the default styles in forms.css):
https://searchfox.org/mozilla-central/search?q=-moz-number-spin-up&path=.css&case=false&regexp=false
https://searchfox.org/mozilla-central/search?q=-moz-number-spin-down&path=.css&case=false&regexp=false

So I don't think there are any more instances of this hiding somewhere. (And since these aren't exposed to web content per bug 1828689 comment 0, we shouldn't run into cases where websites are hitting this same issue themselves.)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1828689

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54537a87e198
Avoid repeated arrows on spin-buttons in print dialog number fields. r=emilio

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/54537a87e198

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-05-02 Nightly build on Windows 10.
Verified as fixed on Firefox 114.0b4(build ID: 20230514175823) and Nightly 115.0a1(build ID: 20230515215623) on Windows 10, macOS 12, Ubuntu 22.