Record all annotations using the new pull-based system and remove the annotation table
Categories
(Toolkit :: Crash Reporting, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Once bug 1776197 all crash annotations will be fetched using the new pull-based system instead of being read over an IPC channel. However all annotations that weren't recorded at crash time are still recorded in the annotation table.
This is a large array, stored in all processes and getting rid of it would reduce memory usage and improve performance, as non-string annotation wouldn't have to be turned into strings every time they are updated.
|
Assignee | |
Updated•11 months ago
|
|
|
Assignee | |
Comment 1•6 months ago
|
||
|
||
Updated•6 months ago
|
|
|
Assignee | |
Comment 2•6 months ago
|
||
Quick update on the patch status: I'm still fixing small issues here and there but it's mostly complete. What's taking long is testing, which needs to happen on all platforms both on 32- and 64-bit builds where supported. Tests don't have sufficient coverage to ensure everything is working fine when applying such a large refactoring.
|
|
||
Updated•5 months ago
|
|
|
Assignee | |
Comment 3•4 months ago
|
||
FYI I've run extensive tests - both manually and in automation - and everything looks fine. I'm waiting for a final review for the graphics/webrender annotations but I won't land this before this weekend's code freeze. Since this is a large refactoring that touches a lot of different areas I'd rather have it bake in nightly for an entire cycle.
|
|
Assignee | |
Comment 4•4 months ago
|
||
I'm landing the first three patches of this stack because they're risk-free, the rest will land after the freeze.
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/efe10c7a4a8d Use the new pull-based API for all crash annotations and remove the global annotations table r=jgilbert,necko-reviewers,media-playback-reviewers,profiler-reviewers,win-reviewers,padenot,handyman,afranchuk,valentin,alwu,sotaro
|
||
Comment 6•2 months ago
|
||
| bugherder | ||
Description
•