1831120 - `GPUBuffer` missing `readonly attribute`s

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Erich Gubler [:ErichDonGubler]]

If you navigate to https://thimbleberry.dev after consuming the patch stack associated with bug 1830762, one encounters the following error in Nightly:

Uncaught (in promise) TypeError: GPURenderPassEncoder.draw: Argument 1 is not a finite value, so is out of range for unsigned long.
    encodeCommands MosaicShader.ts:96
    stampRange ShaderGroup.ts:21
    <snip>

…which is caused by a reference to a GPUBuffer's size attribute being undefined. 😲

It turns out that our implementation of WebGPU doesn't populate the readonly attributes specified to be on GPUBuffer at all! We should, according to section 5.1 ("GPUBuffer") of the current WebGPU v1 spec. draft (link).

Comment 1

[Erich Gubler [:ErichDonGubler]]

Attachment: D177056

Comment 2

[Erich Gubler [:ErichDonGubler]]

Attachment: https://phabricator.services.mozilla.com/D177055

Comment 3

[Erich Gubler [:ErichDonGubler]]

Attachment: https://phabricator.services.mozilla.com/D177056

Comment 4

[Erich Gubler [:ErichDonGubler]]

Sigh, the attachments/patch reviews associated got screwed up, because I typed the wrong bug in my patch messages. They're using a weird Custom policy, and they're not auto-attached, so I did my best with manual attachments, but…it's not the same as what we normally see. 😖

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/402fde4fd386
feat(webgpu): add `GPUBuffer` attributes r=webgpu-reviewers,webidl,saschanaz,jimb
https://hg.mozilla.org/integration/autoland/rev/f4b1acbddf56
style(webgpu): add space b/w `GPUBuffer.{unmap,destroy}` to match spec. r=webgpu-reviewers,webidl,saschanaz,jimb

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/402fde4fd386
https://hg.mozilla.org/mozilla-central/rev/f4b1acbddf56