1831136 - Plumb android text scale factor via nsLookAndFeel.

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1831136 - Plumb android text scale via nsLookAndFeel. r=#layout!,#geckoview-reviewers!

That's how we do it for all other platforms. Do this rather than via a
custom mostly-untested pref, which allows us to simplify text zoom
handling.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b47bd87aa77
Plumb android text scale via nsLookAndFeel. r=geckoview-reviewers,dholbert,owlish

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0b47bd87aa77

Comment 4

[Olivia Hall [:olivia]]

Hi Emilio, thanks for all the help and additional info on bug 1838401!

Could you please take a look at bug 1843749 too? I'm not entirely sure if it could be related to this bug because we are having trouble reproducing and pinpointing the issue, but reading the descriptions makes me wonder if there could be a connection. What makes me think there could be a connection is that the reports fit the same timeline, similar blank frames, and mentioning of differing font sizes. Please let me know if you have any advice for a way we could narrow bug 1843749 down further!

Comment 5

[Emilio Cobos Álvarez (:emilio)]

It shouldn't, but if it is it should be easy to discard by changing the browser.display.os-zoom-behavior to something other than 1. Is that something that could be tested?

Comment 6

[Olivia Hall [:olivia]]

Perfect, thanks for the info!

Comment 7

[Emilio Cobos Álvarez (:emilio)]

The fact that gfx.webrender.software=true fixes bug 1843749 highly points at a driver issue rather than a regression from this patch fwiw. Worst case this patch uncovered it but there's no mention of text scaling in that bug.

Comment 8

[Olivia Hall [:olivia]]

Thanks for the additional info and reading through the reports! It does sound like something may have uncovered an existing issue since someone mentioned seeing the bug once pre-115.

no mention of text scaling in that bug

I think the default on Android is to mirror system scaling, so I was wondering if it could be somehow involved. It is a little indirect, but this one report with smaller text stood out to me, maybe an unrelated issue? There are also a few slight mentions of differing font sizes.

Probably just a red herring, thanks again for taking a look and checking!