1831198 - Some CFR layouts broken for template cfr_doorhanger

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

In latest nightly Fx114, noticed 'Recommendation' notifier in urlbar for template cfr_doorhanger is broken. Opening the bug to investigate regression and track fix.

STR:

1. Set pref browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
2. Open about:newtab#devtools
3. Search for message PERSONALIZED_CFR_MESSAGE , click Show
4. CFR message with layout 'icon_and _message' doesn't render notifier correct in urlbar

Last know build where the message shows correct is Fx106

Comment 1

[Punam Dahiya [:pdahiya]]

Attachment: Personalize-CFR-Message-106.png

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Personalize-CFR-Message-114.png

Comment 3

[Punam Dahiya [:pdahiya]]

Issue is noticed with similar CFR layouts if using address bar notifier such as addon_recommendation and chiclet_open_url showing in urlbar

https://searchfox.org/mozilla-central/rev/e6cb503ac22402421186e7488d4250cc1c5fecab/browser/components/newtab/content-src/asrouter/templates/CFR/templates/ExtensionDoorhanger.schema.json#21

https://searchfox.org/mozilla-central/rev/e6cb503ac22402421186e7488d4250cc1c5fecab/browser/components/newtab/lib/CFRMessageProvider.jsm#80

https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/asrouter/templates/CFR/templates/CFRUrlbarChiclet.schema.json#21

https://searchfox.org/mozilla-central/rev/e6cb503ac22402421186e7488d4250cc1c5fecab/browser/components/newtab/lib/CFRMessageProvider.jsm#674

Comment 4

[Negin]

Unassigning this for the time being to work on P1s incase anyone had bandwidth/wants to grab this.

Comment 5

[hanna A]

Attachment: WIP: Bug 1831198 - Some CFR layouts broken for template cfr_doorhanger

Comment 6

[hanna A]

Attachment: Bug 1831198 - Some CFR layouts broken for template cfr_doorhanger r=#omc-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9741fc277848
Some CFR layouts broken for template cfr_doorhanger r=omc-reviewers,desktop-theme-reviewers,aminomancer

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9741fc277848

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible using the steps from the description on the latest Firefox Nightly 123.0a1 (Build ID: 20231227205835) installed on Windows 10 x64, macOS 14.1.1, and Ubuntu 22.04 x64. I can confirm that the "Personalized CFR Recommendation" button is correctly displayed in the "Address Bar".