1831272 - NS_NET_STATUS_* are clashing with other error codes

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

See bug 1825501 comment 16

OnStatusChange normally passes one of the following values:

NS_NET_STATUS_READING = 0x804B0008,
  NS_NET_STATUS_WRITING = 0x804B0009,
  NS_NET_STATUS_RESOLVING_HOST = 0x804B0003,
  NS_NET_STATUS_RESOLVED_HOST = 0x804B000B,
  NS_NET_STATUS_CONNECTING_TO = 0x804B0007,
  NS_NET_STATUS_CONNECTED_TO = 0x804B0004,
  NS_NET_STATUS_TLS_HANDSHAKE_STARTING = 0x804B000C,
  NS_NET_STATUS_TLS_HANDSHAKE_ENDED = 0x804B000D,
  NS_NET_STATUS_SENDING_TO = 0x804B0005,
  NS_NET_STATUS_WAITING_FOR = 0x804B000A,
  NS_NET_STATUS_RECEIVING_FROM = 0x804B0006,

These seem to clash with the following:

NS_BINDING_REDIRECTED = 0x804B0003,
NS_ERROR_ALREADY_CONNECTED = 0x804B000B,
NS_BINDING_RETARGETED = 0x804B0004,
NS_ERROR_NOT_CONNECTED = 0x804B000C,
NS_ERROR_CONNECTION_REFUSED = 0x804B000D,
NS_ERROR_MALFORMED_URI = 0x804B000A,

I'be also been confused by this when looking at logs before.
Let's change this to SUCCESS(*) instead, if it's not breaking anything.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1831272 - Change NS_NET_STATUS_* to success codes to avoid clashing with other nsresult values r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd9669c17d98
Change NS_NET_STATUS_* to success codes to avoid clashing with other nsresult values r=necko-reviewers,kershaw,devtools-reviewers,bomsy

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cd9669c17d98