1831315 - [wpt-sync] Sync PR 39844 - Reland "Fix painting order of text-shadow on (underline) decorations"

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 39844 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39844
Details from upstream follow.

Fredrik Söderquist <[e-mail]> wrote:

Reland "Fix painting order of text-shadow on (underline) decorations"

This is a reland of commit 4678fac54a6cbf8038e3128d889d47dd5317e941

Original change's description:

Fix painting order of text-shadow on (underline) decorations

The right-most shadow should be at the bottom, so needs to be painted
first (c.f. TextPainterBase::CreateDrawLooper()).

Iterate the text-shadow vector in reverse in
NGTextPainterBase::PaintUnderOrOverLineDecorationShadows().

Fixed: 1442188
Change-Id: I02e0b9909d8280b3e893ca0c58225ae5dca94ace
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4499286
Auto-Submit: Fredrik Söderquist \<[e-mail]>
Reviewed-by: Stephen Chenney \<[e-mail]>
Commit-Queue: Stephen Chenney \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1139099}

Change-Id: I2888ebc914fd7a58a591d3145fd872b10c0dc554

Reviewed-on: https://chromium-review.googlesource.com/4506157
WPT-Export-Revision: 536db905d9ac7e236f34214eeba7dd5803d95888

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Try push failed: decision task MLGCr-xrSVqc4yDMdP7hnw returned error

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b776b61ee4a6fe2fea3269d8e66b5232dd78b8a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36cd744fb75c
[wpt PR 39844] - Reland "Fix painting order of text-shadow on (underline) decorations", a=testonly

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/36cd744fb75c