1831373 - sendRootCommand fails for BiDi modules

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Julian Descottes [:jdescottes]]

There was an implementation bug hidden by the fact that our browser mochitests use a different ModuleRegistry implementation.

We should:

• fix the bug
• update the test registry to be similar to the actual registry
• remove logic from the Registry and put it back in the module cache (Registry should be as basic as possible considering we use different ones in browser mochitests vs real protocol)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1831373 - [remote] Fix sendRootCommand trying to reach root-in-windowglobal layer

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1831373 - [remote] Use a regular ModuleRegistry for MessageHandler browser mochitests

Depends on D177179

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1831373 - [remote] Remove all logic from ModuleRegistry classes

Depends on D177180

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da1d239d23b2
[remote] Fix sendRootCommand trying to reach root-in-windowglobal layer r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/183d03d5568a
[remote] Use a regular ModuleRegistry for MessageHandler browser mochitests r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/7e10ab90c30d
[remote] Remove all logic from ModuleRegistry classes r=webdriver-reviewers,whimboo

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/da1d239d23b2
https://hg.mozilla.org/mozilla-central/rev/183d03d5568a
https://hg.mozilla.org/mozilla-central/rev/7e10ab90c30d