Closed
Bug 1831373
Opened 1 year ago
Closed 1 year ago
sendRootCommand fails for BiDi modules
Categories
(Remote Protocol :: Agent, defect, P1)
Remote Protocol
Agent
Tracking
(firefox114 fixed)
RESOLVED
FIXED
114 Branch
| Tracking | Status | |
|---|---|---|
| firefox114 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
(Whiteboard: [webdriver:m7])
Attachments
(3 files)
There was an implementation bug hidden by the fact that our browser mochitests use a different ModuleRegistry implementation.
We should:
- fix the bug
- update the test registry to be similar to the actual registry
- remove logic from the Registry and put it back in the module cache (Registry should be as basic as possible considering we use different ones in browser mochitests vs real protocol)
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D177179
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D177180
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/da1d239d23b2 [remote] Fix sendRootCommand trying to reach root-in-windowglobal layer r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/183d03d5568a [remote] Use a regular ModuleRegistry for MessageHandler browser mochitests r=webdriver-reviewers,whimboo https://hg.mozilla.org/integration/autoland/rev/7e10ab90c30d [remote] Remove all logic from ModuleRegistry classes r=webdriver-reviewers,whimboo
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/da1d239d23b2
https://hg.mozilla.org/mozilla-central/rev/183d03d5568a
https://hg.mozilla.org/mozilla-central/rev/7e10ab90c30d
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox114:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•