1831411 - MessageHandler.handleCommand with destination "ROOT" runs the command in the content process

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The code as landed on bug 1830404 doesn't correctly work and instead of running the given command in the parent process the root module is actually instantiated in the content process.

This can be verified by adding the following code to the command that needs to be run:

    const isRemote =
      Services.appinfo.processType == Services.appinfo.PROCESS_TYPE_CONTENT;

    if (isRemote) {
      throw new Error("Cannot be run in content process");
    }

Available commands in the root modules will fail. I've added some debugger statements to the MessageHandlerFrameChild and MessageHandlerFrameParent related methods and those are not called at all. IMHO we do not actually forward the command but execute immediately.

A fix for this bug is required for my work on bug 1830884.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1831411 - [remote] Commands send to root modules from windowglobal should run in the parent

Depends on D177181

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f584d752c7ca
[remote] Commands send to root modules from windowglobal should run in the parent r=webdriver-reviewers,Sasha

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f584d752c7ca