1831425 - Popup panel tab order is inconsistent on Windows

Status: RESOLVED FIXED

(Toolkit :: PopupNotifications and Notification Bars, defect, P3)

Description

[Tim Giles [:tgiles]]

Attachment: actual-tab-order.png

The tab order follows the reading order, so for English speaking locales this would be top to bottom, left to right. However on Windows, due to the use of order: -1 in popupnotification.css, this results in the tab focus moving in a unexpected way. In the case of the Firefox Relay panel, the focus moves from the "Learn more" label to the "Not now" button, instead of moving to the "Continue" button.

The focus doesn't jump wildly to somewhere else but the DOM order does not match the visual order. Seems like this issues corresponds to 2.4.3 Focus Order, but I may be conflating the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:hjones, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Hanna Jones [:hjones]]

I believe this was fixed via the changes for Bug 1849192, which removed the order: -1 Windows specific code and implemented moz-button-group in popupnotification.js, which is intended to help standardize button order across different platforms.