1831529 - Intervention cards are executed when trying to access the Help menu

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Note

• Regression affecting the Help menu for several address bar intervention cards: cache firefox, refresh firefox, update firefox

Found in

• Firefox 114.0a1 2023/05/05

Affected versions

• Nightly 114.0a1

Tested platforms

• Affected platforms: all
• Unaffected platforms: -

Steps to reproduce

1. Type cache Firefox in address bar and check the intervention card
2. Hover the Open Menu (...) button and select the Get help button

Expected result
Intervention's card corresponding Sumo page opens.

Actual result
.Clear Recent History modal is opened and then the Sumo page is loaded in background.

Regression range

• First bad: 2023-04-14
• Last good: 2023-04-13
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d75b2841884f42d913e2ad4177c827a21670d9f9&tochange=b9922ca4dcbea173b1679b5a5adc06b54336ea86
• Potentially regressed by: 1827762

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:adw, since you are the author of the regressor, bug 1827762, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1827762

Comment 3

[James Teow [:jteow]]

The fact that this error happened also shows a hole in our test coverage of the usage of the meatball menu.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1831529 - Don't perform the primary intervention action when the help command is clicked.

The provider needs to check whether the help command was picked before
performing the primary action.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09fe594f59f7
Don't perform the primary intervention action when the help command is clicked. r=mak

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 9347510 [details]
Bug 1831529 - Don't perform the primary intervention action when the help command is clicked.

Beta/Release Uplift Approval Request

• User impact if declined: This has been broken since 114, so it would be nice to fix sooner rather than later.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from the comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small patch that only affects the search interventions feature in the urlbar. Has a test.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/09fe594f59f7

Comment 8

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using latest Nightly 118.0a1 across platforms.

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9347510 [details]
Bug 1831529 - Don't perform the primary intervention action when the help command is clicked.

Approved for 117.0b6

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/433d3b5055bd

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed on Firefox 117 beta 6 under Win 10 64-bit, Ubuntu 22.04 and macOS 12.6.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Is this something we need to fix on ESR115 still too? Would need a bit of rebasing if yes.

Comment 13

[Drew Willcoxon :adw]

Yes, this is worth fixing on the ESR. I'll get a patch together, thanks for flagging me.

Comment 14

[Drew Willcoxon :adw]

Attachment: ESR115 patch

ESR Approval Request Comment
[Feature/Bug causing the regression]: This is a regression in the search interventions feature in the urlbar caused by some refactorings and technical changes.
[User impact if declined]: This has been broken since 114, so it would be nice to fix sooner rather than later.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes, should be clear from comments
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Low risk
[Why is the change risky/not risky?]: This is a small patch that only affects the search interventions feature in the urlbar. Has a test.
[String changes made/needed]:

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9349117 [details] [diff] [review]
ESR115 patch

Approved for 115.2esr.

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/2f88e12093dc

Comment 17

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using esr115 treeherder build from Aug 17.