1831689 - Add a pref for the weather suggestion to ignore VPNs and fetch anyway

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

To make testing the weather suggestion easier, let's add a pref to ignore VPNs and fetch anyway.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1831689 - Add a pref for the weather suggestion to ignore VPNs and fetch anyway.

Depends on D177218

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17bc0ddbc36c
Add a pref for the weather suggestion to ignore VPNs and fetch anyway. r=daisuke

Comment 3

[Drew Willcoxon :adw]

STR for QA

We want to make sure browser.urlbar.weather.ignoreVPN = true causes Firefox to show the weather suggestion even when you're on a VPN.

1. Connect to a VPN in a region where the weather suggestion is available (US, Canada, UK, Germany -- no need to test more than one)
2. Set browser.urlbar.weather.ignoreVPN = true -- do not run the usual JS snippet that you previously used
3. Enable the weather suggestion: browser.urlbar.weather.featureGate = true (If you do this step before step 2, Firefox may not show the suggestion because setting browser.urlbar.weather.ignoreVPN does not force a fetch ASAP. If you need to force a fetch after setting the VPN pref, toggle browser.urlbar.weather.featureGate off and back on again, or just restart Firefox.)
4. Type 3 characters of a weather keyword to trigger the suggestion, e.g. wea. If the suggestion appears on zero prefix and not when you type wea, that's fine too, you just need to trigger the suggestion in some way and verify it appears; see bug 1828796 comment 6 for details

Comment 4

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: This bug is necessary for the Firefox Suggest weather suggestion feature we intend to ship in 114.

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9331965 [details]
Bug 1831689 - Add a pref for the weather suggestion to ignore VPNs and fetch anyway.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Firefox Suggest weather suggestion feature we intend to ship in 114.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see comment 3
• List of other uplifts needed: Bug 1831656, bug 1828796, and bug 1831657 must be uplifted first
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Almost trivial patch that only affects the Firefox Suggest weather feature. Has automated tests.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/17bc0ddbc36c

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9331965 [details]
Bug 1831689 - Add a pref for the weather suggestion to ignore VPNs and fetch anyway.

Approved for 114 beta 2, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed550682397b

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 115.0a1 (Build ID: 20230508214159), on Windows 10 x64.

• The preference allows us to trigger weather results when using a VPN client so that we don’t need to use the JS snippet workaround anymore.

Comment 10

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 114.0b2 (Build ID: 20230509180058), on Windows 10 x64.

• The preference allows us to trigger weather results when using a VPN client so that we don’t need to use the JS snippet workaround anymore.