1831691 - Force all mach commands to use the vendored `glean_parser`

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Alex Hochheiden [:ahochheiden] [he/him]]

We can't vendor glean-sdk, but we do already have glean_parser vendored, so we should opt to use it rather than having a loose dependency potentially causing breakages if a new version if pushed to PyPi.

We already do this for the build and python-test sites, but let's just do it for mach overall.

Comment 1

[Alex Hochheiden [:ahochheiden] [he/him]]

Attachment: Bug 1831691 - Use the vendored 'glean_parser' for all of `mach` r?#build

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b58b83f3ba9
Use the vendored 'glean_parser' for all of `mach` r=firefox-build-system-reviewers,glandium

Comment 4

[Jens Stutte [:jstutte]]

I think also moz-phab is affected and after applying the changes from this patch manually, mach build works again but moz-phab does not find the glean module anymore.

Edit: It might just be that I deinstalled all glean instances I could find on my machine, though ;-).

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7b58b83f3ba9

Comment 7

[Jan Alexander Steffens [:heftig]]

This affects downstream (distribution) builds of Firefox 113.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Seems like a pretty trivial backport to ride along in a dot release. Go ahead and nominate for release approval if you agree, Alex!

Comment 9

[Mike Hommey [:glandium]]

This probably affects esr too.

Comment 10

[Alex Hochheiden [:ahochheiden] [he/him]]

Comment on attachment 9331966 [details]
Bug 1831691 - Use the vendored 'glean_parser' for all of mach r?#build

Beta/Release Uplift Approval Request

• User impact if declined: The newest version of glean_parser will be downloaded, which is incompatible with what's in tree.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We already use the a vendored glean_parser for build and python-test, this change makes that version be used everywhere, rather than the newest version be downloaded from PyPi.
• String changes made/needed:
• Is Android affected?: Unknown

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: If this is not done, various mach commands will not work.
• User impact if declined: If this is not done, various mach commands will not work.
• Fix Landed on Version: https://phabricator.services.mozilla.com/rMOZILLACENTRAL7b58b83f3ba9e996187d72051dc4ef413970c043
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9331966 [details]
Bug 1831691 - Use the vendored 'glean_parser' for all of mach r?#build

NPOTB for Firefox builds, but makes life easier for downstream distros. Approved for 113.0.1.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/5c609f7fe205

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9331966 [details]
Bug 1831691 - Use the vendored 'glean_parser' for all of mach r?#build

Approved for 102.12esr also.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/75cfc11a9c1f