Closed Bug 1831764 Opened 1 year ago Closed 10 months ago

Show decrypted protected header "subject" in message list pane when first opening the message

Categories

(MailNews Core :: Security: OpenPGP, defect)

Thunderbird 113
defect

Tracking

(thunderbird_esr115? fixed, thunderbird114 wontfix, thunderbird118? fixed)

RESOLVED FIXED
119 Branch
Tracking Status
thunderbird_esr115 ? fixed
thunderbird114 --- wontfix
thunderbird118 ? fixed

People

(Reporter: martin.monperrus, Assigned: welpy-cw)

References

Details

(Keywords: regression, Whiteboard: [Supernova3p])

Attachments

(1 file)

OpenPGP supports subject encryption via protected headers, which is good (UI option "encrypt the subject of openpgp messages").

Actual behavior:
In the message list pane, encrypted subjects are shown as "...".
(However, for a given message in the message window, the subject is well decrypted. )

Expected behavior:
The message list pane should also show decrypted subjects instead of "...". This would align the message list pane and the message window behavior.

Summary: Show decrypted protected header "subject" in message list pane → Show decrypted protected header "subject" in message list pane in vertical view

The bug does not happen in "Classic View" or "Wide View" layout.
It only happens in "Vertical View".

We had a bug recently, where the subject in the message list wasn't updated at all.
I assumed it's fixed in our recent Beta versions.
You recently mentioned that you're on 113 Beta 1? Is that still true?
Please make sure you test with newest versions, also.

I've tried to reproduce, but cannot, it works for me in vertical view, too.
The decrypted subject is shown as soon as I click the message.

I'm now with 113.0b6, that may explain why I have hard time to see the bug.

I confirm that the decrypted subject is shown as soon as one clicks on the encrypted message.

closing.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED

-> WFM (we use FIXED only when a known patch resolved the issue)

Resolution: FIXED → WORKSFORME

Now I understand.

The subject in the message list is not decrypted when we stay on the message.

If we move to another message and go back, then it is decrypted in the message list.

Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: Show decrypted protected header "subject" in message list pane in vertical view → Show decrypted protected header "subject" in message list pane when first opening the message

This is not from supernova, correct?

Flags: needinfo?(mkmelin+mozilla)
Whiteboard: [snnot3p]

It would be yes. But I don't see it. The moment you decrypted the message, the subject in the list is also updated.

Flags: needinfo?(mkmelin+mozilla)

monperrus, does this still reproduce for you?

Flags: needinfo?(martin.monperrus)
Keywords: regression
Whiteboard: [snnot3p] → [Supernova3p]
Version: unspecified → Thunderbird 113

yes, the bug is still there with 116.0b3.

when I click on the message, only the message pane get the decrypted subject.

to get the list pane updated, I need to move to another message first.

Flags: needinfo?(martin.monperrus)

I wonder what's different, because the thread pane definitely updates instantly for me when the message is loaded. I'm using the classic 3pane view, nothing special about the openpgp setup.

I'm using the vertical view, but the bug happens also with the classic view.

Steps to reproduce:

  1. Open for the first time a message with encrypted subject which has been marked as read before.
  2. Select another message.
  3. Change to another folder and come back.

Actual results:

  1. The actual subject is shown in the message pane, but the subject in the thread pane still shows the ellipsis.
  2. Only now the subject in the thread pane get also updated. Yet in case of a reply the "Re: " is missing.
  3. Now also the "Re: " is shown correctly in the thread pane.

Expected results:

The subject in the thread pane should be updated correctly (including "Re: " if necessary) immediately after opening a message with encrypted subject for the first time, even if that message has been marked as read before.

To easily reproduce without any unopened encrypted messages just copy some into a newly created folder and repair that folder. Then all subjects are shown as ellipses again and the STR are the same.

I just discovered this concerns only unopened encrypted messages which have been marked as read beforehand and have updated the STR accordingly.

Assignee: nobody → h.w.forms
Duplicate of this bug: 1843833
Target Milestone: --- → 119 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/f885fa57a27e
Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

Status: REOPENED → RESOLVED
Closed: 1 year ago11 months ago
Resolution: --- → FIXED

I backed this out. It's breaking mail/test/browser/openpgp/browser_viewMessage.js.

Backout:
https://hg.mozilla.org/comm-central/rev/175fcb7a7e68bb1e04ee1660556b0060c66247ed

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

The test fails since the test opens the messages from a file, hence no folder and no db. Change gMessage.folder.msgDatabase.notifyHdrChangeAll() to gMessage.folder?.msgDatabase.notifyHdrChangeAll().

Fixed gMessage.folder being undefined when opening a saved encrypted mail file by adding optional chaining operator. The affected test passes on my machine.

Pushed by solange@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/adf8b60253eb
Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

Status: REOPENED → RESOLVED
Closed: 11 months ago10 months ago
Resolution: --- → FIXED

Comment on attachment 9352487 [details]
Bug 1831764 - Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

[Triage Comment]
Approved for beta with Kaie's blessing

Attachment #9352487 - Flags: approval-comm-beta+

Excellent, thanks a lot!

Attachment #9352487 - Flags: approval-comm-esr115?

Comment on attachment 9352487 [details]
Bug 1831764 - Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

[Triage Comment]
Approved for esr115
Thanks Hartmut

Attachment #9352487 - Flags: approval-comm-esr115? → approval-comm-esr115+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: