1831764 - Show decrypted protected header "subject" in message list pane when first opening the message

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[monperrus]

OpenPGP supports subject encryption via protected headers, which is good (UI option "encrypt the subject of openpgp messages").

Actual behavior:
In the message list pane, encrypted subjects are shown as "...".
(However, for a given message in the message window, the subject is well decrypted. )

Expected behavior:
The message list pane should also show decrypted subjects instead of "...". This would align the message list pane and the message window behavior.

Comment 1

[monperrus]

The bug does not happen in "Classic View" or "Wide View" layout.
It only happens in "Vertical View".

Comment 2

[Kai Engert [:KaiE:]]

We had a bug recently, where the subject in the message list wasn't updated at all.
I assumed it's fixed in our recent Beta versions.
You recently mentioned that you're on 113 Beta 1? Is that still true?
Please make sure you test with newest versions, also.

I've tried to reproduce, but cannot, it works for me in vertical view, too.
The decrypted subject is shown as soon as I click the message.

Comment 3

[monperrus]

I'm now with 113.0b6, that may explain why I have hard time to see the bug.

I confirm that the decrypted subject is shown as soon as one clicks on the encrypted message.

closing.

Comment 4

[Magnus Melin [:mkmelin]]

-> WFM (we use FIXED only when a known patch resolved the issue)

Comment 5

[monperrus]

Now I understand.

The subject in the message list is not decrypted when we stay on the message.

If we move to another message and go back, then it is decrypted in the message list.

Comment 6

[monperrus]

Now I understand.

The subject in the message list is not decrypted when we stay on the message.

If we move to another message and go back, then it is decrypted in the message list.

Comment 7

[Wayne Mery (:wsmwk)]

This is not from supernova, correct?

Comment 8

[Magnus Melin [:mkmelin]]

It would be yes. But I don't see it. The moment you decrypted the message, the subject in the list is also updated.

Comment 9

[Wayne Mery (:wsmwk)]

monperrus, does this still reproduce for you?

Comment 10

[monperrus]

yes, the bug is still there with 116.0b3.

when I click on the message, only the message pane get the decrypted subject.

to get the list pane updated, I need to move to another message first.

Comment 11

[Magnus Melin [:mkmelin]]

I wonder what's different, because the thread pane definitely updates instantly for me when the message is loaded. I'm using the classic 3pane view, nothing special about the openpgp setup.

Comment 12

[monperrus]

I'm using the vertical view, but the bug happens also with the classic view.

Comment 13

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Open for the first time a message with encrypted subject which has been marked as read before.
2. Select another message.
3. Change to another folder and come back.

Actual results:

1. The actual subject is shown in the message pane, but the subject in the thread pane still shows the ellipsis.
2. Only now the subject in the thread pane get also updated. Yet in case of a reply the "Re: " is missing.
3. Now also the "Re: " is shown correctly in the thread pane.

Expected results:

The subject in the thread pane should be updated correctly (including "Re: " if necessary) immediately after opening a message with encrypted subject for the first time, even if that message has been marked as read before.

Comment 14

[Hartmut Welpmann [:welpy-cw]]

To easily reproduce without any unopened encrypted messages just copy some into a newly created folder and repair that folder. Then all subjects are shown as ellipses again and the STR are the same.

Comment 15

[betterbird.project+10]

We provided a fix in bug 1843833 comment #1:
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1843833-fix-subject-pgp.patch

Comment 16

[betterbird.project+10]

The patch restores this line which shouldn't have been removed:
https://searchfox.org/comm-esr102/rev/6974e100e593040afe3eecddeae15bf2b8b4c4aa/mail/extensions/openpgp/content/ui/enigmailMsgHdrViewOverlay.js#828

Comment 17

[Hartmut Welpmann [:welpy-cw]]

I just discovered this concerns only unopened encrypted messages which have been marked as read beforehand and have updated the STR accordingly.

Comment 18

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1831764 - Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

Based on https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1843833-fix-subject-pgp.patch

Depends on D187772

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f885fa57a27e
Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

Comment 21

[Geoff Lankow (:darktrojan)]

I backed this out. It's breaking mail/test/browser/openpgp/browser_viewMessage.js.

Backout:
https://hg.mozilla.org/comm-central/rev/175fcb7a7e68bb1e04ee1660556b0060c66247ed

Comment 22

[betterbird.project+10]

The test fails since the test opens the messages from a file, hence no folder and no db. Change gMessage.folder.msgDatabase.notifyHdrChangeAll() to gMessage.folder?.msgDatabase.notifyHdrChangeAll().

Comment 23

[Hartmut Welpmann [:welpy-cw]]

Fixed gMessage.folder being undefined when opening a saved encrypted mail file by adding optional chaining operator. The affected test passes on my machine.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/adf8b60253eb
Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

Comment 25

[Wayne Mery (:wsmwk)]

Comment on attachment 9352487 [details]
Bug 1831764 - Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

[Triage Comment]
Approved for beta with Kaie's blessing

Comment 26

[monperrus]

Excellent, thanks a lot!

Comment 27

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/92779ef09ae0

Comment 28

[Wayne Mery (:wsmwk)]

Comment on attachment 9352487 [details]
Bug 1831764 - Restore invalidating the thread tree when setting the subject in PGP code. r=mkmelin

[Triage Comment]
Approved for esr115
Thanks Hartmut

Comment 29

[Daniel Darnell [:dandarnell]]

Thunderbird 115.3.0:
https://hg.mozilla.org/releases/comm-esr115/rev/1218aebde8d8