1831819 - Remove the logic to handle per-global function in gSideEffectFreeNatives

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Tooru Fujisawa [:arai]]

https://phabricator.services.mozilla.com/D175089#inline-979655
Given the target global can be different type for each call, the list of available functions could also be different.
we should calculate the list for each global and cache it in the debugger or webConsole, instead of global variable that's shared across multiple globals.

Comment 1

[Tooru Fujisawa [:arai]]

Actually, this no longer applies because there's no instance methods or instance getters in the current allowlist,
since all DOM getters are allowed and no longer stored into the explicit allowlist.

Now all functions are retrieved from sandbox, and there's no difference depending on the target global.

We can simplify the structure and keep using single map, with bug 1831834.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1831819 - Remove per-global function support in eager evaluation allow list. r?#devtools-reviewers!

Stop supporting instance methods and getters in allowlist.
Now the allowlist is independent of global and can be shared across multiple
globals.

Depends on D178883

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6a25ac049e4
Remove per-global function support in eager evaluation allow list. r=devtools-reviewers,nchevobbe

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 3 changesets (Bug 1831819, Bug 1832769, Bug 1831826) for causing build bustages in Object-isSameNativeWithJitInfo.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=260ffbbe45e0d474d615675f1b7fc496611e4aa4&selectedTaskRun=IlJAEALaS52l8TbydfOmsQ.0

Log: https://treeherder.mozilla.org/logviewer?job_id=417122900&repo=autoland&lineNumber=27920

Backout: https://hg.mozilla.org/integration/autoland/rev/d659b70ec02be8ad2ab084872ca6ac6a3d4165d3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b45ad38d9a1
Remove per-global function support in eager evaluation allow list. r=devtools-reviewers,nchevobbe

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9b45ad38d9a1