Print Preview freezing tab when loading a column layout based document
Categories
(Core :: Print Preview, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox113 | --- | wontfix |
firefox114 | --- | verified |
firefox115 | --- | verified |
People
(Reporter: vlucaci, Assigned: TYLin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
174.31 KB,
application/zip
|
Details | |
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Found in
- 114.0a1 (2023-05-07)
Affected versions
- 113.0-build2
- 114.0a1 (2023-05-07)
Tested platforms
- Affected platforms: macOS 13, Ubuntu 22, Windows 11
- Unaffected platforms: none
Steps to reproduce
- Launch FF.
- Go to this website
- Print Preview (CTRL+P)
Expected result
- The webpages is print previewed without any issues.
Actual result
- The page does not load inside print preview and the tab becomes unresponsive
Regression range
- First bad: 2022-08-10
- Last good: 2022-08-09
- Pushlog: autoland:pushlog
- Potentially regressed by: 793686
Additional notes
- This issue has been investigated and submitted as part of this Support Question.
Comment 1•1 year ago
|
||
:TYLin, since you are the author of the regressor, bug 793686, could you take a look?
For more information, please visit BugBot documentation.
Updated•1 year ago
|
Assignee | ||
Comment 2•1 year ago
|
||
I can reproduce this issue with the saved website. I think the column-balancing algorithm is trapped in an infinite loop in print preview because of some break-inside:avoid
elements.
Assignee | ||
Comment 3•1 year ago
|
||
A top-level multicol in a paginated context can be fragmented. We should use the
same logic to set the mIsTopOfPage
bit as if the multicol is a nested one.
WARNING: loading the testcase without this patch can trap Firefox in an infinite
loop.
Updated•1 year ago
|
Assignee | ||
Updated•1 year ago
|
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1620189277fc Consider multicol container in paginated context when setting mIsTopOfPage bit. r=emilio
Comment 5•1 year ago
|
||
bugherder |
Comment 6•1 year ago
|
||
The patch landed in nightly and beta is affected.
:TYLin, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox114
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 7•1 year ago
|
||
Comment on attachment 9332532 [details]
Bug 1831829 - Consider multicol container in paginated context when setting mIsTopOfPage bit.
Beta/Release Uplift Approval Request
- User impact if declined: Browser can freeze in printing or printing preview if the page cotains multi-column layout and
break-inside:avoid
elements. - Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's low risky because it's a one line change (modulo the comment update) and the code path is the same as nested multi-column layout
- String changes made/needed: None
- Is Android affected?: Yes
Comment 8•1 year ago
|
||
Comment on attachment 9332532 [details]
Bug 1831829 - Consider multicol container in paginated context when setting mIsTopOfPage bit.
Approved for 114 beta 4, thanks.
Comment 9•1 year ago
|
||
bugherder uplift |
Updated•1 year ago
|
Updated•1 year ago
|
Reporter | ||
Comment 10•1 year ago
|
||
Hello,
Confirming this issue as verified fixed on 114.0b4 (20230514175823) and 115.0a1 (20230514213610) using macOS 13, Ubuntu 22 and Windows 11.
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40215 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Description
•