1831852 - Telemetry runs jemalloc_stats twice, iterating over the heap unnecessarily

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Paul Bone [:pbone]]

The two calls here:

https://searchfox.org/mozilla-central/source/xpcom/base/MemoryTelemetry.cpp#285-287

Each iterate over the jemalloc heap. They should be able to iterate over the heap once and re-use the data.

This is a very minor optimisation, I'm working on it because I noticed it when I begun making other changes to the code here.

Comment 1

[Alessio Placitelli [:Dexter]]

The telemetry component is for bugs related to the data collection system. Product or consumer related bugs should live in the Bugzilla component of the owner of the collecting piece.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1831852 - Use const refs for the HeapOverhead parameter r=mccr8

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1831852 - Avoid extra call to jemalloc_stats in telemetry r=mccr8

Depends on D177595

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b84a41087a1
Use const refs for the HeapOverhead parameter r=mccr8
https://hg.mozilla.org/integration/autoland/rev/e0498c17978e
Avoid extra call to jemalloc_stats in telemetry r=mccr8

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5b84a41087a1
https://hg.mozilla.org/mozilla-central/rev/e0498c17978e