1831909 - [meta] OpenPGP strings with poor pluralization

Status: RESOLVED WORKSFORME

(MailNews Core :: Security: OpenPGP, defect, P2)

Description

[Rob Lemley [:rjl]]

messagecomposer.ftl has some strings that can't be translated into some languages because of poor use of plurals.

https://firefox-source-docs.mozilla.org/l10n/fluent/review.html#variants-and-plurals

Need plurals

• openpgp-key-issue-notification-many
• smime-cert-issue-notification-many

Split into multiple strings
This needs two strings, one for the case of 1 public recipient, and a plural string that handles > 1.

• many-public-recipients-notice

An example from browser:

https://searchfox.org/mozilla-central/rev/4e6970cd336f1b642c0be6c9b697b4db5f7b6aeb/browser/locales/en-US/browser/tabbrowser.ftl#70-76

# The singular form is not considered since this string is used only for multiple tabs.
# Variables:
#   $tabCount (Number): The number of tabs that will be closed.
tabbrowser-confirm-close-tabs-title =
    { $tabCount ->
       *[other] Close { $tabCount } tabs?
    }

Addon-fix:
openpgp-key-issue-notification-one
This string is missing a period at the end of the sentence. It should align with the other strings in this section which all have one. This does change the string enough that a new ID is going to be needed.

Comment 1

[Kai Engert [:KaiE:]]

looking...

Comment 2

[Kai Engert [:KaiE:]]

Rob, does this need to be fixed by May 11 ?

Comment 3

[Rob Lemley [:rjl]]

Before 115 goes to beta. I suspect we'll be able to migrate some of these. Once you've identified what the new Fluent code will be, NI? me about a script.

Comment 4

[Rob Lemley [:rjl]]

I'm going to add another to this bug:
messenger.ftl - decrypt-and-copy-failure

# Variables:
# $failures (Number) - Number of messages that could not be decrypted.
# $total (Number) - Total number of messages that were attempted to be decrypted.
decrypt-and-copy-failures = { $failures } of { $total } messages could not be decrypted and were not copied.

This needs plurals based on $total.

Also needing plurals in mail/messenger/openpgp/keyWizard.ftl:

• openpgp-keygen-days-label
• openpgp-keygen-months-label
• openpgp-keygen-years-label

Comment 5

[Elizabeth Mitchell]

Making this a meta bug so things can get fixed more quickly.

Comment 6

[Elizabeth Mitchell]

(In reply to Rob Lemley [:rjl] from comment #0)

Split into multiple strings
This needs two strings, one for the case of 1 public recipient, and a plural string that handles > 1.

• many-public-recipients-notice

The current code is the following. Has this already been fixed?

#   $count (Number) - the count of addresses in the "To" and "Cc" fields.
many-public-recipients-notice = { $count ->
  [one] Your message has a public recipient. You can avoid disclosing recipients by using Bcc instead.
  *[other] The { $count } recipients in To and Cc will see each other’s address. You can avoid disclosing recipients by using Bcc instead.
}

Comment 7

[Elizabeth Mitchell]

Rob is checking in on how to handle pluralization when we are doing something special for a single case (see phabricator comment.) Pluralization related updates are on hold for now.

Comment 8

[Rob Lemley [:rjl]]

As mentioned in D178066, there's no guarantee that the [one] variant or any variant will be present for a given locale. So the singular case needs to be a separate string and then a plural string with only [other] variant.

Comment 9

[Rob Lemley [:rjl]]

Some more in openpgp.ftl:

• openpgp-key-gen-days-label
• openpgp-key-gen-months-label
• openpgp-key-gen-years-label

I'll note that 1 day/month/year is an accepted value, so a plural with [1] and [other] variants should suffice.

Comment 10

[Magnus Melin [:mkmelin]]

Those are actually not in use. Will file a bug.

Comment 11

[Elizabeth Mitchell]

Are plurals still needed for the below?:
(In reply to Rob Lemley [:rjl] from comment #4)

Also needing plurals in mail/messenger/openpgp/keyWizard.ftl:

• openpgp-keygen-days-label
• openpgp-keygen-months-label
• openpgp-keygen-years-label

The following translations were addressed in bug 1833762 by being removed, as they were not in use.
(In reply to Rob Lemley [:rjl] from comment #9)

Some more in openpgp.ftl:

• openpgp-key-gen-days-label
• openpgp-key-gen-months-label
• openpgp-key-gen-years-label

I'll note that 1 day/month/year is an accepted value, so a plural with [1] and [other] variants should suffice.

The other translation updates have been addressed.

Comment 12

[Magnus Melin [:mkmelin]]

(In reply to Elizabeth Mitchell from comment #11)

Are plurals still needed for the below?:
(In reply to Rob Lemley [:rjl] from comment #4)

Also needing plurals in mail/messenger/openpgp/keyWizard.ftl:

• openpgp-keygen-days-label
• openpgp-keygen-months-label
• openpgp-keygen-years-label

Those are correct. They are used directly as items in a menu. https://searchfox.org/comm-central/rev/1924a0c102a4d3a75af572a16336e4b8056d0d3f/mail/extensions/openpgp/content/ui/keyWizard.xhtml#252,259,265

Comment 13

[Elizabeth Mitchell]

(In reply to Magnus Melin [:mkmelin] from comment #12)

(In reply to Elizabeth Mitchell from comment #11)

Are plurals still needed for the below?:
(In reply to Rob Lemley [:rjl] from comment #4)

Also needing plurals in mail/messenger/openpgp/keyWizard.ftl:

• openpgp-keygen-days-label
• openpgp-keygen-months-label
• openpgp-keygen-years-label

Those are correct. They are used directly as items in a menu. https://searchfox.org/comm-central/rev/1924a0c102a4d3a75af572a16336e4b8056d0d3f/mail/extensions/openpgp/content/ui/keyWizard.xhtml#252,259,265

I think we can close this then. All items have been addressed. Thank you! Please reopen if I missed something.

Comment 14

[Wayne Mery (:wsmwk)]

=> WFM because it doesn't have a patch