1831920 - Add support for casting function types

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P2)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

The casting instructions can support downcasting to a specific function type. We currently don't support this because our function object representation doesn't have the type information easily accessible.

Comment 1

[Ben Visness [:bvisness]]

Attachment: Bug 1831920: Implement casting for all remaining wasm types. r=rhunt

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:bvisness, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b454d7da6a13
Implement casting for all remaining wasm types. r=rhunt,jandem

Comment 4

[Cristian Tuns]

Backed out for causing jsreftest failures in eval-export-dflt-cls-anon.js

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | js/src/tests/test262/language/expressions/dynamic-import/eval-export-dflt-cls-anon.js;module;async | No test results reported. (SCRIPT)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aaf1339f918
Implement casting for all remaining wasm types. r=rhunt,jandem a=reland

Comment 6

[Natalia Csoregi [:nataliaCs]]

Relanded this patch as it is not the cause for the permafailures mentioned in the above comment.

We apologise for the inconvenience caused!

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8aaf1339f918