1831963 - Enable the translations pref for Nightly

Status: RESOLVED FIXED

(Firefox :: Translations, task, P2)

Description

[Greg Tatum [:gregtatum]]

Once the UX feedback in Bug 1820247 I'm going to see about enabling this by default in Nightly.

Comment 1

[Greg Tatum [:gregtatum]]

:flod is it ok to have the ftl files still in locales preview to do this?

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Greg Tatum [:gregtatum] from comment #1)

:flod is it ok to have the ftl files still in locales preview to do this?

I would really prefer to have the strings exposed first, or very close. What's the timeline on that?

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Enable the translations feature in Nightly and Early Beta; r?nordzilla!

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Add Translations modules to known list of content process scripts; r?nordzilla!

Depends on D178461

Comment 5

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Remove duplicate ids in translations code; r?nordzilla!

Comment 6

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Ensure new TranslationParent actors are created for each test; r?nordzilla!

I was getting a weird intermittent locally, and I believe this was the
cause.

Comment 7

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Use a lazy pref getter for translations chaos mode; r?nordzilla!

Comment 8

[Greg Tatum [:gregtatum]]

If anyone is following along, turning things on by default caused a few tests to fail on try.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/260c6f5b72e6
Enable the translations feature in Nightly and Early Beta; r=marco,nordzilla
https://hg.mozilla.org/integration/autoland/rev/b691f7c48bf9
Add Translations modules to known list of content process scripts; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/ab6c15a5c8fb
Remove duplicate ids in translations code; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/ced39405b51e
Ensure new TranslationParent actors are created for each test; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/e2653450faa8
Use a lazy pref getter for translations chaos mode; r=nordzilla

Comment 10

[Greg Tatum [:gregtatum]]

I found a CI bug that I overlooked in the intermittents, so this will probably fail:

browser/base/content/test/performance/browser_preferences_usage.js | browser.translations.logLevel should not be accessed more than 40 times. - 100 <= 40 -

Comment 11

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Use a lazy pref getter for the log level in translations; r?nordzilla!

Comment 12

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Remove the bypassSignatureVerificationIfDev check; r?nordzilla!

This is another raw preference read, and rather than rewrite it, we were
wanting to get rid of this anyway.

Depends on D179274

Comment 13

[Sandor Molnar[:smolnar]]

Backed out for causing failures related to translation

Backout link: https://hg.mozilla.org/integration/autoland/rev/b45b68be3f9bae0da4d649a44e60c6cd175f2212

Push with failures

Failure log -> Mn

Failure log -> bc

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New cool feature
[Affects Firefox for Android]: Not yet
[Suggested wording]: Local translation - improvement welcome :)
[Links (documentation, blog post, etc)]:

Comment 15

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Change Fluent button messages to use the label; r?nordzilla!

This fixes errors surfaced in:

browser/components/tests/marionette/test_no_errors_clean_profile.py

Visually and functionally the buttons work fine, but it generates a
warning that is caught by this test.

Depends on D179275

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/baaaaff4b660
Enable the translations feature in Nightly and Early Beta; r=marco,nordzilla
https://hg.mozilla.org/integration/autoland/rev/c4811197740c
Add Translations modules to known list of content process scripts; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/493c07c8a519
Remove duplicate ids in translations code; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/f730091705fd
Ensure new TranslationParent actors are created for each test; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/522ef5669a6b
Use a lazy pref getter for translations chaos mode; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/5b15a7632c91
Use a lazy pref getter for the log level in translations; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/44cd611f57ce
Remove the bypassSignatureVerificationIfDev check; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/2b8bba99a0df
Change Fluent button messages to use the label; r=nordzilla,fluent-reviewers,flod

Comment 17

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_preferences_usage.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | browser.translations.logLevel should not be accessed more than 40 times. - 50 <= 40 - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js","name":"checkPrefGetters","sourceId":584,"lineNumber":42,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chr

Comment 18

[Greg Tatum [:gregtatum]]

Attachment: Bug 1831963 - Add "browser.translations.logLevel" to the allow list on browser_preferences_usage.js; r?nordzilla!

Depends on D179360

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b04d1071d52
Enable the translations feature in Nightly and Early Beta; r=marco,nordzilla
https://hg.mozilla.org/integration/autoland/rev/4345e2c1dfce
Add Translations modules to known list of content process scripts; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/8931a4032409
Remove duplicate ids in translations code; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/cf320e1acdcf
Ensure new TranslationParent actors are created for each test; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/fb0d1c351634
Use a lazy pref getter for translations chaos mode; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/d097f1b2494b
Use a lazy pref getter for the log level in translations; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/20c5ff6af30a
Remove the bypassSignatureVerificationIfDev check; r=nordzilla
https://hg.mozilla.org/integration/autoland/rev/930913e9cca6
Change Fluent button messages to use the label; r=nordzilla,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/7e0621d3a953
Add "browser.translations.logLevel" to the allow list on browser_preferences_usage.js; r=nordzilla

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8b04d1071d52
https://hg.mozilla.org/mozilla-central/rev/4345e2c1dfce
https://hg.mozilla.org/mozilla-central/rev/8931a4032409
https://hg.mozilla.org/mozilla-central/rev/cf320e1acdcf
https://hg.mozilla.org/mozilla-central/rev/fb0d1c351634
https://hg.mozilla.org/mozilla-central/rev/d097f1b2494b
https://hg.mozilla.org/mozilla-central/rev/20c5ff6af30a
https://hg.mozilla.org/mozilla-central/rev/930913e9cca6
https://hg.mozilla.org/mozilla-central/rev/7e0621d3a953

Comment 21

[Donal Meehan [:dmeehan]]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #14)

Release Note Request (optional, but appreciated)
[Why is this notable]: New cool feature
[Affects Firefox for Android]: Not yet
[Suggested wording]: Local translation - improvement welcome :)
[Links (documentation, blog post, etc)]:

Added to the nightly release notes

Comment 22

[Ryan VanderMeulen [:RyanVM]]

This is riding the Fx117 trains via bug 1820261. Updating the relnote accordingly.

Comment 23

[Donal Meehan [:dmeehan]]

Removed from the 117 release notes, keeping on the radar for 118