Closed
Bug 1831966
Opened 2 years ago
Closed 2 years ago
Update PiP fullscreen control tooltip
Categories
(Toolkit :: Picture-in-Picture, task)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
115 Branch
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | fixed |
People
(Reporter: kpatenio, Assigned: kpatenio)
References
Details
(Whiteboard: [fidefe-pip3])
Attachments
(1 file)
Bug 1724915 allows users to toggle fullscreen mode for PiP using the "f" key. The fullscreen toggle's tooltip currently only shows "double-click" and not this new shortcut (searchfox). We should be sure that the text is updated to include the f key shortcut.
Furthermore, the shortcut is a hardcoded value. Ideally, we want to expose it to localization, which allows localizers to change the shortcut if deemed necessary. We similarly do this for the PiP keyboard shortcut.
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
Attachment #9332970 -
Attachment description: WIP: Bug 1831966 - update PiP fullscreen control tooltip and expose it to l10n. r=#pip-reviewers! → Bug 1831966 - update PiP fullscreen control tooltip and expose it to l10n. r=#pip-reviewers!
Pushed by kpatenio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c323d7a4dfbf
update PiP fullscreen control tooltip and expose it to l10n. r=fluent-reviewers,dwalker,flod
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox115:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•