Closed Bug 1832032 Opened 1 year ago Closed 10 months ago

HTMLInputElement::IntrinsicState, which is rather slow, is called multiple times when parsing an element with several attributes

Categories

(Core :: DOM: Core & HTML, defect, P2)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1850161

People

(Reporter: smaug, Assigned: emilio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

UpdateState, which then calls IntrinsicState(), is called on any attribute change https://searchfox.org/mozilla-central/rev/373d05f4eabdb90a6480d5d36d983b8bff36c9d8/dom/base/Element.cpp#2661
and also when binding HTMLInputElement to tree
https://searchfox.org/mozilla-central/rev/373d05f4eabdb90a6480d5d36d983b8bff36c9d8/dom/html/HTMLInputElement.cpp#4305

Either we need to call UpdateState less often or make HTMLInputElement::IntrinsicState faster.

I'll mark this S2 because it is related to Speedometer. Feel free to adjust.

Severity: -- → S2
Whiteboard: [sp3]

Had another offline discussion, moving this to S3/P2.

Severity: S2 → S3
Priority: -- → P2
Depends on: 1833181

IntrinsicState is gone, UpdateState is no longer called for every attr change..

Status: NEW → RESOLVED
Closed: 10 months ago
Duplicate of bug: 1850161
Resolution: --- → DUPLICATE
Assignee: nobody → emilio
You need to log in before you can comment on or make changes to this bug.