1832081 - File Icons in Sources tree update when file is selected

Status: VERIFIED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2023-05-09 at 15.13.33.mp4

1. Go to https://fx-devtools-codemirror5-long-lines.glitch.me/
2. Open the debugger
3. Select longline.js in the sources tree
4. Wait a bit, all the icon for the visible files are updated to the react icon
5. Select script.js in the sources tree

-> All the icon for the visible files are updated back to the JS icon

(See screencast attached)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

mozregression points to Bug 1814177

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1814177

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1832081 - [devtools] Fix SourceTree icons always matching the currently selected source.

Prevent using the exact same icon for all sources matching the currently selected one,
instead make it specific to each displayed source.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa170b66896e
[devtools] Fix SourceTree icons always matching the currently selected source. r=devtools-reviewers,nchevobbe

Comment 5

[Atila Butkovits]

Backed out for causing Talos failures at browser-toolbox.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/9fc6fbfccedcdd087b3525c99520abe5221a6249

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=T187SbQkTnWvhW9AP22dQg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=damp&revision=488a1a8b33a0c427f85d10224a2f8db913e22b16

Failure log: https://treeherder.mozilla.org/logviewer?job_id=416187843&repo=autoland&lineNumber=2102

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0677372d9a86
[devtools] Fix SourceTree icons always matching the currently selected source. r=devtools-reviewers,nchevobbe

Comment 7

[Norisz Fay [:noriszfay]]

Push has been relanded after finding the real culprit.

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/0677372d9a86

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ochameau, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-05-09 Nightly build on Windows 10.
Verified as fixed on Firefox 115.0b4(build ID: 20230611180300) and Nightly 116.0a1(build ID: 20230612211509) on Windows 10, macOS 12, Ubuntu 22.