1832101 - html.css sets only 1 border side for `[rules]` table elements

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[:Gijs (away/busy until Mar 10)]

See: https://searchfox.org/mozilla-central/rev/373d05f4eabdb90a6480d5d36d983b8bff36c9d8/layout/style/res/html.css#393-395,398-399

table[rules][rules="groups"] > tfoot,
table[rules][rules="groups"] > thead,
table[rules][rules="groups"] > tbody {
...
  border-block-start-style: solid;
  border-block-start-style: solid;

I'm dropping the dupe when introducing stylelint in bug 1508369, which flagged this up.

I/we suspect this should have been start/end in the original patch. But nobody appears to have noticed, so we probably want a test and/or be a bit more careful about reintroducing this.

Comment 1

[Jonathan Kew [:jfkthame]]

I've pushed https://treeherder.mozilla.org/jobs?repo=try&revision=3c0930c2be5fc42ebac20890c5187df0bce684e8 to see whether any current reftests notice the change. (If not -- which I think is likely -- we should create one.)

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1832101 - Fix typo in UA stylesheet table rules, introduced in bug 1119475. r=#layout-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e212dc9646fe
Fix typo in UA stylesheet table rules, introduced in bug 1119475. r=layout-reviewers,dholbert

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39966 for changes under testing/web-platform/tests

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e212dc9646fe

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot