1832105 - The Feedback menu options don’t work anymore if an option was previously clicked and the Address Bar panel remains open

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Nightly 115.0a1 (Build ID: 20230508214159)
• Firefox Nightly 114.0b1 (Build ID: 20230508175934)

[Affected Platforms]:

• Windows 10 x64
• Linux Ubuntu 20.04 x64
• macOS 12.4

[Prerequisites]:

• Have a VPN client connected to a US server ( make sure the browser.search.region pref is set accordingly).
• Have the Firefox Nightly 115.0a1 build installed.
• Set the following prefs:
  browser.urlbar.weather.featureGate = true
  (Windows only) browser.urlbar.weather.ignoreVPN = true

[Steps to reproduce]:

1. Open the browser from the prerequisites.
2. Type the “weather” string in the Address Bar.
3. Click the Feedback button.
4. Click any of the first 2 options (“Report inaccurate location” or “Show less frequently”).
5. Click the Feedback button again.
6. Click any of the Dismiss options from the sub-menu (“Not relevant” or “Not interested”).
7. Observe the behavior.

[Expected result]:

• The weather suggestion is removed from the Address Bar panel and a Thank you message with the “Got it” button is displayed.

[Actual result]:

• Nothing happens, the weather result remains displayed.

[Notes]:

• We noticed that even though the dismiss buttons don’t work, the telemetry is incremented with each click for firefox-suggest-weather-command-not-relevant and firefox-suggest-weather-command-not-interested (depending on which one is clicked).
• Here is the screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: This bug is necessary for the Firefox Suggest weather suggestion feature we intend to ship in 114.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1832105 - Add the weather suggestion commands to the isSessionOngoing logic in the urlbar telemetry event code.

The problem is the two weather commands that keep the view open,
"inaccurate_location" and "show_less_frequently", aren't included in the
criteria that set isSessionOngoing to true.

As the comment above isSessionOngoing says, we should find a better way to
determine whether the session remains ongoing than hardcoding a list of
commands. I didn't try to do that here since we're time constrained and need to
uplift this to 114.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e5722e588df
Add the weather suggestion commands to the isSessionOngoing logic in the urlbar telemetry event code. r=daisuke

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9332502 [details]
Bug 1832105 - Add the weather suggestion commands to the isSessionOngoing logic in the urlbar telemetry event code.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Firefox Suggest weather suggestion feature we intend to ship in 114.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from bug description
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch that only affects urlbar telemetry related to the weather suggestion. Has tests.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0e5722e588df

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9332502 [details]
Bug 1832105 - Add the weather suggestion commands to the isSessionOngoing logic in the urlbar telemetry event code.

Approved for 114 beta 3, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/4a85013a232b

Comment 8

[Carmen Fat [:cfat] - Ecosystem QA]

We have verified this issue on the latest Firefox Nightly 115.0a1 (Build ID: 20230511094802) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The Weather suggestion can be removed in the same Address Bar session using any of the “Not relevant” or “Not interested” options after previously choosing any of the "Report inaccurate location" or "Show less frequently" options.

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

We have verified this issue on the latest Firefox Beta 114.0b3 (Build ID: 20230511191645) on Windows 10 x64, macOS 12.6.1, and Ubuntu 20.04 x64.

• The Weather suggestion can be removed in the same Address Bar session using any of the “Not relevant” or “Not interested” options after previously choosing any of the "Report inaccurate location" or "Show less frequently" options.