Closed Bug 1832177 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 39912 - [anchor-position] Generally allow out-of-flow anchors

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
firefox115 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 39912 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/39912
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

[anchor-position] Generally allow out-of-flow anchors

As decided in https://github.com/w3c/csswg-drafts/issues/8165, anchoring
to out-of-flow anchors should be generally allowed, as long as the
anchor comes earlier in the tree order. This patch implements the
change.

Since we are already calling NGLogicalAnchorQuery::Set() for out-of-flow
anchors, this patch only changes the insertion algorithm to not filter
then out, and the query algorithm to consider out-of-flow anchors.

Existing support of top-layer target elements is covered by this change,
and hence its special handling code is remove.

Bug: 1442752
Change-Id: I81e80a143447369d1fb3c5a4aee587760cfb913f
Reviewed-on: https://chromium-review.googlesource.com/4518512
WPT-Export-Revision: 682951c460e6495d820b7b19519e1e8ba2eeec7e

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 5 tests and 4 subtests

Status Summary

Firefox

OK : 5
PASS: 6
FAIL: 52

Chrome

OK : 5
PASS: 39
FAIL: 19

Safari

OK : 5
PASS: 6
FAIL: 52

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-anchor-position/anchor-name-002.html [wpt.fyi]
    • .target 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 4: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 5: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 6: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-anchor-position/anchor-name-003.html [wpt.fyi]
    • .target 2: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 3: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 4: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 5: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 6: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 7: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 9: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 10: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 11: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 12: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 13: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 14: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 16: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 17: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 18: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 19: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 20: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 21: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 22: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 23: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 24: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 25: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 26: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 27: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 28: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 29: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 31: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 32: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 33: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 34: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 35: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 36: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 37: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-anchor-position/anchor-name-multicol-003.html [wpt.fyi]
    • .target 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 2: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 3: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 4: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-anchor-position/anchor-position-multicol-003.html [wpt.fyi]
    • .target 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 2: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 3: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 4: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 5: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 6: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 7: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-anchor-position/anchor-position-multicol-fixed-001.html [wpt.fyi]
    • .target 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • .target 2: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 3: FAIL (Chrome: PASS, Safari: FAIL)
    • .target 4: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3e0e257d2bc [wpt PR 39912] - [anchor-position] Generally allow out-of-flow anchors, a=testonly https://hg.mozilla.org/integration/autoland/rev/c868e402c6ff [wpt PR 39912] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e3e0e257d2bc
https://hg.mozilla.org/mozilla-central/rev/c868e402c6ff

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox115: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.