1832254 - Verify if we can/should have a wrapping runnable for the background task

Status: RESOLVED FIXED

(Toolkit :: Background Tasks, task)

Description

[Jens Stutte [:jstutte]]

Note also that there are things that potentially do something after the RunBackgroundTask returned (thus after any timeout we add there this is not true, as any async/await will actually make us return and dispatch a new delayed runnable that will then continue the execution. So we might return even in the middle of the execution and then enter our main loop):

1. AddScreenWakeLockListener(); (I wonder if that can ever be useful for background tasks?)
2. GetTopSEHFilter(); (not sure how to follow the code path here, but setting exception handlers might have OS level side effects hard to control?)

I wonder if we should better wrap the background task into a runnable we dispatch to the main thread, letting it be executed later on top of our normal message loop run? Apart from the above, if ever something was able to dispatch events asynchronously to MT before we come here, we would run them before our payload runs.

Comment 1

[Jens Stutte [:jstutte]]

Probably we should leave the task detection synchronous for immediate error return but wrap starting from here.

Comment 2

[Jens Stutte [:jstutte]]

Attachment: Bug 1832254 - Have a slightly delayed runnable that wraps the background task execution start. r?nalexander,saschanaz

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3271b312f8cf
Have a slightly delayed runnable that wraps the background task execution start. r=nalexander,saschanaz

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3271b312f8cf