1832455 - Remove or update probes expiring in Firefox 116: pictureinpicture.* before Gecko version gets increased to 116 on 2023-06-05

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, task)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 116 [1].

pictureinpicture.backward#backward
pictureinpicture.backward_sequence#backward_sequence
pictureinpicture.forward#forward
pictureinpicture.forward_sequence#forward_sequence
pictureinpicture.seek#seek

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Tracking because at least toolkit/components/pictureinpicture/tests/browser_improved_controls.js depends on this.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Can I presume we want to keep / renew these probes for now, Ania?

Comment 3

[Ania]

We mostly had them to ensure everything was ok in the 113 release and gather information on whether our current backward/forward seek is too short. I feel like it's somewhat safe to remove them in 116, but do you think we might want them for some additional reasons (I wasn't sure if we want to collect such a ubiquitous event for a long time when we originally added it).

Comment 4

[Molly Howell (she/her) (no longer active)]

We're running out of time, I'm just going to take this bug and remove the probes.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Ack, thanks for taking this mhowell!

Comment 6

[Ania]

Thank you, Molly!

Comment 7

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1832455 - Remove expiring PIP events and associated tests. r=#pip-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6771e3f10aa7
Remove expiring PIP events and associated tests. r=pip-reviewers,kpatenio

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6771e3f10aa7