Closed Bug 1832455 Opened 1 year ago Closed 1 year ago

Remove or update probes expiring in Firefox 116: pictureinpicture.* before Gecko version gets increased to 116 on 2023-06-05

Categories

(Toolkit :: Picture-in-Picture, task)

task

Tracking

()

RESOLVED FIXED
115 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox113 --- unaffected
firefox114 --- unaffected
firefox115 --- fixed

People

(Reporter: telemetry-probes, Assigned: molly)

References

Details

(Whiteboard: [probe-expiry-alert])

Attachments

(1 file)

The following Firefox probes will expire in the next major Firefox nightly release: version 116 [1].

pictureinpicture.backward#backward
pictureinpicture.backward_sequence#backward_sequence
pictureinpicture.forward#forward
pictureinpicture.forward_sequence#forward_sequence
pictureinpicture.seek#seek

What to do about this:

  1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
  2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Tracking because at least toolkit/components/pictureinpicture/tests/browser_improved_controls.js depends on this.

Flags: needinfo?(mhowell)
Summary: Remove or update probes expiring in Firefox 116: pictureinpicture.* → Remove or update probes expiring in Firefox 116: pictureinpicture.* before Gecko version gets increased to 116 on 2023-06-05

Can I presume we want to keep / renew these probes for now, Ania?

Flags: needinfo?(asafko)

We mostly had them to ensure everything was ok in the 113 release and gather information on whether our current backward/forward seek is too short. I feel like it's somewhat safe to remove them in 116, but do you think we might want them for some additional reasons (I wasn't sure if we want to collect such a ubiquitous event for a long time when we originally added it).

Flags: needinfo?(asafko) → needinfo?(mconley)

We're running out of time, I'm just going to take this bug and remove the probes.

Assignee: nobody → mhowell
Status: NEW → ASSIGNED
Flags: needinfo?(mhowell)
Flags: needinfo?(mconley)

Ack, thanks for taking this mhowell!

Thank you, Molly!

Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6771e3f10aa7
Remove expiring PIP events and associated tests. r=pip-reviewers,kpatenio
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: